Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinmap design doc #9690

Merged
merged 9 commits into from Feb 19, 2019

Conversation

Projects
None yet
6 participants
@c1728p9
Copy link
Contributor

commented Feb 12, 2019

Description

I couldn't push to #8693 so I opened this to make updates to the pinmap design document.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change
@c1728p9

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

Make the following changes from #8693:

  • Update design doc content
  • Updated design doc to follow the template
  • Rebased onto master

PR which brought pinmap main-line is #9449 .

Docs for pinmap can be found in ARMmbed/mbed-os-5-docs#930.

@c1728p9

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

@fkjagodzinski
Copy link
Member

left a comment

Only one thing to fix.

cmonr and others added some commits Feb 13, 2019

Make targets plural in design document
Co-Authored-By: c1728p9 <butleja10511@hotmail.com>
Update table of content links
Update the links and names in the table of contents.

@c1728p9 c1728p9 force-pushed the c1728p9:pinmap-design-doc branch to b63b302 Feb 13, 2019

@cmonr

cmonr approved these changes Feb 13, 2019

@cmonr cmonr requested a review from AnotherButler Feb 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@AnotherButler Please review

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

CI started whilst final review comes in

@cmonr cmonr added ready for merge and removed needs: review labels Feb 19, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

Bringing in now to unblock other PRs that might be dependent on this.

@AnotherButler will submit a seperate PR for doc fixes if needed.

@cmonr cmonr merged commit f4e6db2 into ARMmbed:master Feb 19, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9279 cycles (-86 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 19, 2019

@c1728p9 c1728p9 deleted the c1728p9:pinmap-design-doc branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.