Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target: UBLOX: Fix build warning in UBLOX_AT_CellularNetwork.cpp #9692

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
6 participants
@naveenkaje
Copy link
Contributor

naveenkaje commented Feb 12, 2019

Description

Fix this build warning seen when building with ARMCC

Compile [ 13.7%]: UBLOX_AT_CellularNetwork.cpp
[Warning] UBLOX_AT_CellularNetwork.cpp@65,0:  #111-D: statement is unreachable

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
target: UBLOX: Fix build warning in UBLOX_AT_CellularNetwork.cpp
Fix this build warning seen when building with ARMCC

Compile [ 13.7%]: UBLOX_AT_CellularNetwork.cpp
[Warning] UBLOX_AT_CellularNetwork.cpp@65,0:  #111-D: statement is unreachable

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 12, 2019

@naveenkaje, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Feb 12, 2019

Copy link
Contributor

cmonr left a comment

Ahhh, that's a funky warning to get rid of.

Makes sense to me.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 12, 2019

CI started whist final review comes in.

Betting on reviewer being OK with changes

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@jarvte

jarvte approved these changes Feb 13, 2019

@cmonr cmonr added ready for merge and removed needs: review labels Feb 13, 2019

@cmonr cmonr merged commit e310458 into ARMmbed:master Feb 13, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9215 cycles (-884 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.