Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor psa entropy inject test #9701

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
6 participants
@orenc17
Copy link
Contributor

commented Feb 13, 2019

Description

Replace TEST_ASSERT with more specific assertions

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-test Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@Patater
Copy link
Contributor

left a comment

Refactoring looks good, thanks.

I have questions about the new device lifetime function call and assert.

Show resolved Hide resolved TESTS/psa/entropy_inject/main.cpp

orenc17 added some commits Feb 13, 2019

Refactor psa entropy inject test
Replace TEST_ASSERT with more specific assertions
Clear ITS environment in psa entropy tests
mbed_psa_reboot_and_request_new_security_state() API replaced its_reset() which is now a secure API only

This change is necessary for a clean environment for the test

@orenc17 orenc17 force-pushed the kfnta:entorpy_inject_test_refactor branch to eb48d3c Feb 13, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@Patater changed the commit message as requested

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

CI started

@cmonr

cmonr approved these changes Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

CI started.

Will wait on @teetak01 to ack before merging

Sorry, wrong PR.

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 13, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit da57191 into ARMmbed:master Feb 13, 2019

25 checks passed

continuous-integration/jenkins/pr-head @cmonr: Disregard forced status update. Webpage cache issue...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10611 cycles (+1266 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 13, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 14, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.