Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies of platform partition #9702

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
6 participants
@orenc17
Copy link
Contributor

commented Feb 13, 2019

Description

Fix an issue in PSA partitions

  • Note to maintainers a PR updating the secure binaries will be opened later today

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa

@mikisch81
Copy link
Contributor

left a comment

Note to myself, update #9653 as well

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Fix an issue in PSA partitions

What issue? How this addresses it ? Can you expand the commit msg, the code change looks simple so the msg could also be short but informative

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

The issue is that the platform partition on PSA boards calls its_reset API,
on K64F its a non-issue because the lack of SPM but on FUTURE_SEQUANA it will crash in the secure side

The change looks big due to the auto-generation of SPM code

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 13, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-IAR

@cmonr cmonr added needs: CI and removed needs: review labels Feb 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

Restarting CI.

Single job failure did not list any FAIL artifacts, indicating something likely went wring within Jenkins

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

And sure enough, it looks like the single job hit a GitHub 502 timeout.

Interesting...

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 13, 2019

@cmonr cmonr merged commit 704a1cb into ARMmbed:master Feb 13, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9836 cycles (+491 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.