Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix cellular stack and drivers for netsocket tests #9705

Merged
merged 6 commits into from Feb 19, 2019

Conversation

Projects
None yet
7 participants
@AriParkkila
Copy link
Contributor

commented Feb 13, 2019

Description

Fix cellular stack and drivers:

  • Handling of TCP endpoint closed
  • AT debugging relieved
  • Cinterion drivers to retry on socket open failure
  • Various fixes for Quectel BG96 and M26 drivers

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

@ciarmcom ciarmcom requested review from mirelachirica and ARMmbed/mbed-os-maintainers Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-socket-gt branch Feb 14, 2019

Show resolved Hide resolved features/cellular/framework/AT/AT_CellularStack.cpp
Show resolved Hide resolved ...res/cellular/framework/targets/QUECTEL/M26/QUECTEL_M26_CellularStack.cpp Outdated

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-socket-gt branch Feb 15, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@mirelachirica please re-review

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Trying to understand the need to squash all these fixes into one. Why?

I would rather leave them as described:

  • Handling of TCP endpoint closed
  • AT debugging relieved
  • Cinterion drivers to retry on socket open failure
  • Various fixes for Quectel BG96 and M26 drivers

Than having all in one.

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@0xc0170 do you mean that one commit per each change, if so I can split this to many commits.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@0xc0170 do you mean that one commit per each change, if so I can split this to many commits.

yes, please if you agree that they can be separated logically into own commits.

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-socket-gt branch Feb 18, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

@0xc0170 split to logical commits, should be ready for merge.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 18, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

Thanks for the rework, looks good.
For future reference, describe fixings with "how is this being fixed and why". This is good as it is "Cellular: Fix CellularDevice mutex unlock" but commit like "Cellular: Handling of TCP endpoint closed" might be better with a description.

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 18, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 18, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Feb 18, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

Please review test failures

@AriParkkila AriParkkila force-pushed the AriParkkila:cellular-socket-gt branch to 605a42d Feb 18, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 19, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 19, 2019

@0xc0170 0xc0170 merged commit 400fd82 into ARMmbed:master Feb 19, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10280 cycles (+1126 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.