Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only GCC_ARM toolchain is supported, removing legacy code #9714

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
5 participants
@deepikabhavnani
Copy link
Contributor

commented Feb 13, 2019

Description

GCC_CR / GCC_CWL and all other flavors of GCC are not supported in Mbed OS. Removing the linker files not in use.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri

@cmonr cmonr requested review from ARMmbed/team-nxp and SenRamakri Feb 13, 2019

@cmonr

cmonr approved these changes Feb 13, 2019

Copy link
Contributor

left a comment

Sounds sensible to me.

@cmonr cmonr added the needs: review label Feb 13, 2019

@0xc0170
Copy link
Member

left a comment

Nice cleanup

@mmahadevan108
Copy link
Contributor

left a comment

Thank you

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 14, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 15, 2019

@cmonr cmonr merged commit 5701c94 into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9432 cycles (+67 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Unsure why, but this PR didn't like being applied to the mbed-os-5.11 branch. Retargeting for 5.12.

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:cleanup_linker_files branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.