Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash sum check #9722

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
7 participants
@theamirocohen
Copy link
Contributor

theamirocohen commented Feb 14, 2019

Description

Check that flash size sum up to all sectors combined.
The sector map can be printed if wanted.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-storage

Add flash sum check
Check that flash size sum up to all sectors combined

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 14, 2019

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

deepikabhavnani commented Feb 14, 2019

Check that flash size sum up to all sectors combined. The sector map can be printed if wanted.

I am confused regarding the purpose of the test, please share some background information. when will sector size of all sectors not match the flash size?

@davidsaada

This comment has been minimized.

Copy link
Contributor

davidsaada commented Feb 14, 2019

Check that flash size sum up to all sectors combined. The sector map can be printed if wanted.

I am confused regarding the purpose of the test, please share some background information. when will sector size of all sectors not match the flash size?

Trigger was a flash driver we have got, that included a hard coded sector map, instead of querying the device.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

deepikabhavnani commented Feb 14, 2019

Trigger was a flash driver we have got, that included a hard coded sector map, instead of querying the device.

Ok, that explains. Thanks 👍

@cmonr

cmonr approved these changes Feb 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 15, 2019

@0xc0170 0xc0170 merged commit 1554b0c into ARMmbed:master Feb 15, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10474 cycles (-44 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.