Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/utils: ensure default build profiles are processed first #9724

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
6 participants
@naveenkaje
Copy link
Contributor

naveenkaje commented Feb 14, 2019

Description

The command-line argument --profile looks for build profiles provided in mbed-os/tools/profiles/. If a
directory exists in the root folder with the same name as one of the profile names provided by default [e.g debug/develop/release], that directory is processed instead, resulting in an error. Fix this behavior by processing the default profiles first.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @bridadan

@naveenkaje

This comment has been minimized.

Copy link
Contributor Author

naveenkaje commented Feb 14, 2019

Fix for #8498

tools/utils: ensure default build profiles are processed first
The command-line argument '--profile' looks for build
profiles provided in mbed-os/tools/profiles/. If a
directory name exists in the root folder with the
same name as one of the profile names provided by
default [e.g debug/develop/release], that directory
is processed instead resulting in incorrect behavior.
Fix this behavior by processing the default profiles first.

@naveenkaje naveenkaje force-pushed the naveenkaje:tools_dir_with_profile_name branch to 176b750 Feb 14, 2019

@naveenkaje naveenkaje requested a review from bulislaw Feb 14, 2019

@ciarmcom ciarmcom requested review from bridadan , theotherjimmy and ARMmbed/mbed-os-maintainers Feb 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 14, 2019

@bridadan
Copy link
Contributor

bridadan left a comment

Thanks for the fix!

@naveenkaje naveenkaje requested review from bridadan and removed request for ARMmbed/mbed-os-maintainers Feb 14, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr

cmonr approved these changes Feb 15, 2019

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 15, 2019

@cmonr cmonr merged commit 883b8b8 into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10011 cycles (-507 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.