Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greentea: Remove TLSSocket_simultaneous test #9730

Merged
merged 1 commit into from Feb 19, 2019

Conversation

@michalpasztamobica
Copy link
Contributor

michalpasztamobica commented Feb 15, 2019

Description

The reason is that some platforms lack memory to run it. To be brought back once TLS library memory consumption is optimized.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@VeijoPesonen
@mtomczykmobica
@KariHaapalehto
@tymoteuszblochmobica

Release Notes

TESTS/netsocket/tls/main.cpp Outdated
@@ -196,7 +196,10 @@ Case cases[] = {
Case("TLSSOCKET_SEND_TIMEOUT", TLSSOCKET_SEND_TIMEOUT),
Case("TLSSOCKET_NO_CERT", TLSSOCKET_NO_CERT),
#ifndef __IAR_SYSTEMS_ICC__

This comment has been minimized.

@SeppoTakalo

SeppoTakalo Feb 15, 2019

Contributor

I think we should remove the #ifndef __IAR as well.

This comment has been minimized.

@michalpasztamobica

michalpasztamobica Feb 15, 2019

Author Contributor

Good point. I removed it, but added a further warning comment, so someone doesn't spend hours debugging this test in case it gets uncommented in distant future.

Greentea: Remove TLSSocket_simultaneous test
The reason is that some platforms lack memory to run it. To be brought
back once TLS library memory consumption is optimized.

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:tlssocketsimultaneous_temporary_removal branch to a089661 Feb 15, 2019

@ciarmcom ciarmcom requested review from KariHaapalehto , mtomczykmobica , SeppoTakalo , tymoteuszblochmobica , VeijoPesonen and ARMmbed/mbed-os-maintainers Feb 15, 2019

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

michalpasztamobica commented Feb 19, 2019

@0xc0170 , @cmonr , could we please get this PR merged in? I am getting more and more tickets from the nightly builds asking me to fix TLSSOCKET_SIMULTANEOUS test failures... :)

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 19, 2019

While we can get at least one more review, CI started

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 19, 2019

The reason is that some platforms lack memory to run it. To be brought back once TLS library memory consumption is optimized.

As this is being skipped, is there tracking issue for reenabling this test case? Is not #8306 ?

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

michalpasztamobica commented Feb 19, 2019

@VeijoPesonen , @KariHaapalehto , @mtomczykmobica , @tymoteuszblochmobica , can we get at least one more code review here, please?

@0xc0170 , to track the IAR heap allocation fix there is an issue, that I am subscribed to.

@SeppoTakalo , you mentioned that TLS library memory allocation is being looked at - is there a ticket to track this?

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 19, 2019

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 19, 2019

I see exporters were restarted, failure was in CI script

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

michalpasztamobica commented Feb 19, 2019

Yes, I restarted them after I saw the failure message. If we can get this in before the nightly build start, the results will get cleaner tomorrow.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 19, 2019

CI job restarted: jenkins-ci/exporter

@cmonr

cmonr approved these changes Feb 19, 2019

@cmonr cmonr merged commit 4cbcc36 into ARMmbed:master Feb 19, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9252 cycles (-112 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: review label Feb 19, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 19, 2019

@KariHaapalehto @mtomczykmobica @tymoteuszblochmobica
Premature appologies since I brought this in without your reviews. @SeppoTakalo has already reviewed and it was requested to have this in for nightlies.

@jussisip

This comment has been minimized.

Copy link

jussisip commented Feb 20, 2019

@0xc0170 , @cmonr , could we please get this PR merged in? I am getting more and more tickets from the nightly builds asking me to fix TLSSOCKET_SIMULTANEOUS test failures... :)

Test has been skipped now from nightly run, thnx.

@SeppoTakalo SeppoTakalo deleted the michalpasztamobica:tlssocketsimultaneous_temporary_removal branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.