Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/test/cmsis: add license header #9736

Merged
merged 9 commits into from Feb 20, 2019

Conversation

Projects
None yet
5 participants
@0xc0170
Copy link
Member

0xc0170 commented Feb 15, 2019

Description

Adding license headers for tools/test/cmsis files. One cmsis file was MIT, rereleasing it under apache 2.0 (our implementation) - it was the only file in there.

This touches few areas but maintainers + tools team should be sufficient for approvals (tools team to check if all licenses are correct).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 15, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 15, 2019

@0xc0170 I think the __init__ files need to remain empty. Iirc, they're specifically empty as a hack to enable importing.

@bridadan @theotherjimmy Please correct me if I'm wrong.

@cmonr cmonr added needs: work and removed needs: review labels Feb 15, 2019

@bridadan

This comment has been minimized.

Copy link
Contributor

bridadan commented Feb 15, 2019

I think the __init__ files need to remain empty. Iirc, they're specifically empty as a hack to enable importing.

Nope, you can put whatever you like in it actually (as long as its valid python) 😄. It's also not a hack, its just how python handles modules!

@0xc0170

This comment has been minimized.

Copy link
Member Author

0xc0170 commented Feb 18, 2019

I was thinking if we keep them empty. They should all have licenses as it's file as any other.

@0xc0170

This comment has been minimized.

Copy link
Member Author

0xc0170 commented Feb 18, 2019

I've noticed travis failures, pushed a fix

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_licenses_files branch to 195965f Feb 19, 2019

@0xc0170

This comment has been minimized.

Copy link
Member Author

0xc0170 commented Feb 19, 2019

Travis was fixed (strings before imports), ready for another review round

@cmonr

cmonr approved these changes Feb 19, 2019

Copy link
Contributor

cmonr left a comment

It bothers me that 195965f was the fix.

Oh well. LGTM.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 19, 2019

@0xc0170 0xc0170 merged commit 7f4475d into ARMmbed:master Feb 20, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9090 cycles (-64 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 deleted the 0xc0170:fix_licenses_files branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.