Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyocd requirement and update icetea. #9740

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
4 participants
@bridadan
Copy link
Contributor

bridadan commented Feb 15, 2019

Description

This change was prompted by the concerns raised here: #9481 (comment). This removes pyocd from Mbed OS's tools requirements.

Icetea depends on mbed-flasher. mbed-flasher recently released a version
that drops the dependency on pyocd. Icetea released a version that uses
this latest version of mbed-flasher. So now that pyocd is no longer in
our dependency tree, we can drop it here.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Remove pyocd requirement and update icetea.
Icetea depends on mbed-flasher. mbed-flasher recently released a version
that drops the dependency on pyocd. Icetea released a version that uses
this latest version of mbed-flasher. So now tht pyocd is no longer in
our dependency tree, we can drop it here.

@bridadan bridadan requested a review from cmonr Feb 15, 2019

@0xc0170
Copy link
Member

0xc0170 left a comment

Less dependencies, better :-)

@bridadan

This comment has been minimized.

Copy link
Contributor Author

bridadan commented Feb 15, 2019

@ChiefBureaucraticOfficer has requested this to land for 5.11.5

@cmonr

cmonr approved these changes Feb 15, 2019

@cmonr

cmonr approved these changes Feb 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 15, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 15, 2019

Restarted export since failure seems unrelated to PR.

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 15, 2019

@cmonr cmonr merged commit 3a301cd into ARMmbed:master Feb 15, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/build-ARMC6 Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/cloud-client-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/exporter Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/greentea-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/mbed2-build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/mbed2-build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/mbed2-build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9740/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10282 cycles (+918 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.