Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: export: MCUXpresso: fix case inconsistencies in .templ file names #9742

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
5 participants
@naveenkaje
Copy link
Contributor

naveenkaje commented Feb 15, 2019

Description

The templ file names are both all upper case and lower case letters.
The Target Names map is usually all upper case. The match could fail
if the templ file, as we have case-sensitive comparison. Handle such
cases by perorming a case-insensitve check.

mbed export of a project to MCUXpresso could potentially always fail
irrespective of what is passed in -m option since the target names
map entry and the filename may not match. This commit fixes this issue.

Example of the issue that this commit fixes:

$ mbed export -i mcuxpresso -m lpc11u68 -v
<snip>
project.py: error: LPC11U68 not supported by mcuxpresso
<snip>

And, update copyright.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@bridadan @theotherjimmy

@naveenkaje

This comment has been minimized.

Copy link
Contributor Author

naveenkaje commented Feb 15, 2019

Fixes #9115

tools: export: MCUXpresso: fix case inconsistencies in .templ file names
The templ file names are both all upper case and lower case letters.
The Target Names map is usually all upper case. The match could fail
if the templ file, as we have case-sensitive comparison. Handle such
cases by perorming a case-insensitve check.

mbed export of a project to MCUXpresso could potentially always fail
irrespective of what is passed in -m option since the target names
map entry and the filename may not match. This commit fixes this issue.

Example of the issue that this commit fixes:

$ mbed export -i mcuxpresso -m lpc11u68 -v
<snip>
project.py: error: LPC11U68 not supported by mcuxpresso
<snip>

@naveenkaje naveenkaje force-pushed the naveenkaje:mcuxpresso_export_fix branch to 8d284cb Feb 15, 2019

@ciarmcom ciarmcom requested review from bridadan , theotherjimmy and ARMmbed/mbed-os-maintainers Feb 15, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 15, 2019

@naveenkaje naveenkaje requested review from bridadan and removed request for ARMmbed/mbed-os-maintainers and bridadan Feb 15, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Feb 15, 2019

@cmonr

cmonr approved these changes Feb 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 16, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit f95ec95 into ARMmbed:master Feb 16, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/build-ARMC6 Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/cloud-client-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+48 bytes)
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/exporter Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/greentea-test Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/mbed2-build-ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/mbed2-build-GCC_ARM Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/mbed2-build-IAR Success
Details
jenkins-ci/ARMmbed/mbed-os/mbed-os-ci/PR-9742/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9320 cycles (-583 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.