Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support in more types then just RSA_KEYPAIR #9755

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
7 participants
@netanelgonen
Copy link
Contributor

commented Feb 19, 2019

remove a workaround that was saved for future use.
after this change, if the type is not supported the psa_crypto will return the error code for unsupported

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@itayzafrir

Release Notes

@ciarmcom ciarmcom requested review from itayzafrir and ARMmbed/mbed-os-maintainers Feb 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@netanelgonen, thank you for your changes.
@itayzafrir @ARMmbed/mbed-os-maintainers please review.

@itayzafrir
Copy link
Contributor

left a comment

LGTM

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

CI started

@netanelgonen netanelgonen force-pushed the netanelgonen:fix_support branch Feb 19, 2019

Netanel Gonen
support in more types then just RSA_KEYPAIR
if the type is not supported the psa_crypto will return the error code
for unsupported

@netanelgonen netanelgonen force-pushed the netanelgonen:fix_support branch to 1a87f24 Feb 19, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Why was this rebased? no comment left

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

CI restarted

@netanelgonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

@0xc0170 This was not rebased only a small change inserted,
no comment was left here but @itayzafrir requested a changing "face to face"
additional parentheses around the 2nd part of the if statement

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

The above result was prior to the rebase.

Another comment will be posted once the current CI run completes.

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit f527a8f into ARMmbed:master Feb 19, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9213 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Moved to 5.12 due to failures with 5.11 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.