Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config header to assembly compilation #9765

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
9 participants
@orenc17
Copy link
Contributor

orenc17 commented Feb 19, 2019

Description

Add missing config header for assembly file in ARMC6.
This Fixes an inconsistency between toolchains
GCC and ARMC5 are already doing this
IAR has a solution implemented as well

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy @deepikabhavnani @mikisch81

Release Notes

@ciarmcom ciarmcom requested review from deepikabhavnani , mikisch81 , theotherjimmy and ARMmbed/mbed-os-maintainers Feb 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Feb 19, 2019

@orenc17 orenc17 force-pushed the kfnta:asm_config branch Feb 19, 2019

@cmonr

cmonr approved these changes Feb 19, 2019

Copy link
Contributor

cmonr left a comment

Thanks for the updated details!

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 19, 2019

CI started

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 19, 2019

Would still like feedback from @theotherjimmy and @mikisch81 before merging.

Should be a quick review.

@theotherjimmy
Copy link
Contributor

theotherjimmy left a comment

This makes the behavior consistent for all of the compilers.

@mikisch81
Copy link
Contributor

mikisch81 left a comment

LGTM

Add config header to assembly compilation
ARMC6 was not including mbed_config.h when compiling assembly files

@orenc17 orenc17 force-pushed the kfnta:asm_config branch to 156bdc4 Feb 19, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

orenc17 commented Feb 19, 2019

Reverted the changes in IAR

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 20, 2019

Test run: FAILED

Summary: 2 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 20, 2019

restarted CI

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 20, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 20, 2019

@0xc0170 0xc0170 merged commit 3aeff7a into ARMmbed:master Feb 20, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10308 cycles (+3 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.