Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding STM32_L475 as a new MTB target #9777

Merged
merged 5 commits into from Feb 21, 2019

Conversation

Projects
None yet
7 participants
@ashok-rao
Copy link
Contributor

ashok-rao commented Feb 20, 2019

Description

Adding STM32_L475 MCU only (on a Module Carrier Board) as a new MTB target. This will be used as a base MCU for upcoming cellular MODEMs and other connectivity Module Expansion Boards (MEB).

Greentea logs attached below:
MTB_STM_L475_GT_ARMCC_Pass.txt
MTB_STM_L475_GT_GCC_Pass.txt
MTB_STM_L475_GT_IAR_Pass.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170 @cmonr

Release Notes

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

ashok-rao commented Feb 20, 2019

@0xc0170 @cmonr : Any chance this can get in for the next patch release? We are waiting for release of a cellular Pelion reference design as well based on availability of this target in the OS.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 20, 2019

@0xc0170 @cmonr : Any chance this can get in for the next patch release? We are waiting for release of a cellular Pelion reference design as well based on availability of this target in the OS.

Marked for 5.11.5, should be in if reviewed soon

@0xc0170
Copy link
Member

0xc0170 left a comment

Just one small fix

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

ashok-rao commented Feb 20, 2019

Just one small fix

Done in 2nd and 3rd commit. SPDX identifier added to all new files.

@cmonr

cmonr approved these changes Feb 20, 2019

Copy link
Contributor

cmonr left a comment

LGTM

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 20, 2019

@ashok-rao Does this not also need a review by @ARMmbed/team-st-mcd ?

@ashok-rao

This comment has been minimized.

Copy link
Contributor Author

ashok-rao commented Feb 20, 2019

Thanks @cmonr .
@jeromecoutant was looking into it. Not sure if there are any further comments or is it green ..?

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 20, 2019

Kk. Will hold off on starting CI until @jeromecoutant is able to OK it.

@cmonr

This comment has been minimized.

Copy link
Contributor

cmonr commented Feb 21, 2019

CI started for now, since current load is light.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 21, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

NirSonnenschein commented Feb 21, 2019

CI started

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Feb 21, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 21, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Feb 21, 2019

CI restarted

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 21, 2019

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Feb 21, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 21, 2019

@cmonr cmonr merged commit bba538c into ARMmbed:master Feb 21, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10134 cycles (+1010 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 21, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Feb 27, 2019

@ashok-rao For future reference, any text underneath the # Release Notes section will be taken as text for our release documentation. Thus please add things like test results to the Description in the future. I have moved them for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.