Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUCLEO_L073RZ Bootloader support #9792

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
7 participants
@sarahmarshy
Copy link
Contributor

commented Feb 21, 2019

Description

Add bootloader support for NUCLEO_L073RZ.

Depends on - #9791 and #9798

Pull request type

[ X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@sarahmarshy, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-core please review.

@sarahmarshy sarahmarshy force-pushed the sarahmarshy:nucleo-gcc-bootloader branch Feb 21, 2019

@cmonr cmonr added the do not merge label Feb 21, 2019

@sarahmarshy sarahmarshy force-pushed the sarahmarshy:nucleo-gcc-bootloader branch Feb 21, 2019

@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Hi
I think you can remove the "do not merge" from title and from label,
and use only the preceding PR label ?

@sarahmarshy sarahmarshy force-pushed the sarahmarshy:nucleo-gcc-bootloader branch to 44bc123 Feb 21, 2019

@sarahmarshy sarahmarshy changed the title DO NOT MERGE - NUCLEO_L073RZ Bootloader support for GCC NUCLEO_L073RZ Bootloader support for GCC Feb 21, 2019

@cmonr cmonr removed the do not merge label Feb 21, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@sarahmarshy Is the intention for this to come into 5.11.5 as well?

@sarahmarshy

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

@cmonr, I don't think it matters. It just needs to be on master at some point.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Kk. Checking since Code Freeze for 5.11.5 is today 😁

@sarahmarshy sarahmarshy changed the title NUCLEO_L073RZ Bootloader support for GCC NUCLEO_L073RZ Bootloader support Feb 21, 2019

define symbol __intvec_start__ = 0x08000000;
define symbol __region_ROM_start__ = 0x08000000;
define symbol __region_ROM_end__ = 0x0802FFFF;
#if !defined(MBED_APP_START)

This comment has been minimized.

Copy link
@jeromecoutant

jeromecoutant Feb 22, 2019

Contributor

It seems that this line doesn't compile...

I could see from other targets something like:
if (!isdefinedsymbol(MBED_APP_START)) { define symbol MBED_APP_START = 0x08000000; }

This comment has been minimized.

Copy link
@sarahmarshy

sarahmarshy Feb 22, 2019

Author Contributor

Good call. I've updated it.

@sarahmarshy sarahmarshy force-pushed the sarahmarshy:nucleo-gcc-bootloader branch 2 times, most recently to 22abea3 Feb 22, 2019

@sarahmarshy

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

@ARMmbed/mbed-os-maintainers the two preceding PRs were merged. Can that label be removed?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@ARMmbed/mbed-os-maintainers the two preceding PRs were merged. Can that label be removed?

Done, waiting for @jeromecoutant approval

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 25, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

CI started

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Changes in this will might clash with 2-region update #9571 (comment)

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Changes in this will might clash with 2-region update #9571 (comment)

Good point, how to proceed? This is quite simple PR so can be easily rebased

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

It will be good to rebase this PR on #9571 and update the linker files accordingly, as new sections are added.

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Also changes from #9766 should be picked

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added risk: G risk: A and removed risk: G labels Feb 25, 2019

@0xc0170 0xc0170 removed the needs: CI label Feb 26, 2019

@cmonr cmonr added needs: CI and removed needs: preceding PR labels Feb 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

Marking this as needs: CI to retest post-IAR8 changes.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Ci will be restarted (iar8 exporter issue we will resolve separately).

@deepikabhavnani

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

#9766 might need rebase after this is merged.

Exporter issue is not present in CI now, @cmonr - Was CI restarted on this? Shows all success

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

@deepikabhavnani It was.

Am doing a local merge check before offically merging PRs.

Er, my mistake. Thought #9776 was RfM. You're right, this might cause a rebase to be needed.

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

Was CI restarted on this?

Yes, I think.

@cmonr cmonr merged commit 4b9d07a into ARMmbed:master Mar 1, 2019

32 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10503 cycles (+296 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.