Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Update to Mbed Crypto 1.0.0d5 and then to 1.0.0d6 #9795

Merged
merged 2 commits into from Feb 26, 2019

Conversation

Projects
None yet
8 participants
@Patater
Copy link
Contributor

commented Feb 21, 2019

Description

Update Mbed Crypto to development snapshot 1.0.0d5. This brings backwards compatbility with previous PSA Crypto error codes for use by the PSA Compliance tests.

Depends on PR #9708 and will need a rebase atop it afterwards.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-crypto, @avolinski

Release Notes

Previously, calls to psa_crypto_*_setup() would succeed even if a user did not initialize their operation context. Help users of the PSA Crypto API catch their own bugs by returning PSA_ERROR_BAD_STATE when a setup function is called with an uninitialized context.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Functionality change

Can you add Release notes section above ?

@Patater

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

There is no functionality change between released versions of Mbed OS, only between Mbed Crypto as present in the yet unmerged #9708 and this PR. Do we still want release notes?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

There is no functionality change between released versions of Mbed OS, only between Mbed Crypto as present in the yet unmerged #9708 and this PR. Do we still want release notes?

If 9708 captures it, then all fine.

@Patater

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

If both are merged, there is no functional change.

After updating this PR to include Mbed Crypto 1.0.0d6, there will indeed be a functional change.

@ciarmcom ciarmcom requested review from avolinski and ARMmbed/mbed-os-maintainers Feb 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@Patater, thank you for your changes.
@avolinski @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

@Patater Patater force-pushed the Patater:update-mbedcrypto-1.0.0d5 branch from af71d3f Feb 21, 2019

@Patater

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

Rebased to update to 1.0.0d6, which does actually have some functional changes. Will add release notes.

@@ -29,7 +29,7 @@

# Set the Mbed Crypto release to import (this can/should be edited before
# import)
CRYPTO_RELEASE ?= mbedcrypto-1.0.0d2
CRYPTO_RELEASE ?= mbedcrypto-1.0.0d6

This comment has been minimized.

Copy link
@NirSonnenschein

NirSonnenschein Feb 21, 2019

Contributor

did you mean mbedcrypto-1.0.0d5 or mbedcrypto-1.0.0d6
as in the headline?

This comment has been minimized.

Copy link
@Patater

Patater Feb 22, 2019

Author Contributor

Updated headline to explain what we are doing now. Originally, this was just d5, now it is both d5 and then d6.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

@Patater Rebase when able!

#9708 is now in.

@Patater Patater force-pushed the Patater:update-mbedcrypto-1.0.0d5 branch to e5c1e0b Feb 22, 2019

@Patater Patater changed the title crypto: Update to Mbed Crypto 1.0.0d5 crypto: Update to Mbed Crypto 1.0.0d5 and then to 1.0.0d6 Feb 22, 2019

@Patater

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Rebased atop latest master.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 22, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

@Patater As it's Friday, reviews are expected on Sunday due weekend? I'll schedule CI test run now

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 22, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 22, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Restarting CI (failure unrelated, and seems in the CI rather)

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 22, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added needs: review and removed needs: CI labels Feb 22, 2019

@Patater

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

@dgreen-arm has approved on behalf of @ARMmbed/mbed-os-crypto

Awaiting review from @avolinski team

@cmonr

cmonr approved these changes Feb 25, 2019

Copy link
Contributor

left a comment

A bit concerned about the PSA defines used since a lot of PSA activity is moving about, but I think it should be fine.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Awaiting review from @avolinski team

@cmonr cmonr added the risk: A label Feb 25, 2019

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 26, 2019

@cmonr cmonr merged commit bf92043 into ARMmbed:master Feb 26, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9343 cycles (-864 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.