Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to disable writing developer certificate #9804

Merged
merged 3 commits into from Feb 27, 2019

Conversation

Projects
None yet
8 participants
@aashishc1988
Copy link
Contributor

commented Feb 21, 2019

Description

Addresses #8178

We have an option now "--disable-cert" for "mbed dm init" which disables writing developer certificate to mbed_cloud_dev_credentials.c

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Release Notes

It is possible now to disable writing developer certificate to mbed_cloud_dev_credentials using an option --no-developer-cert with "mbed dm init" command

@aashishc1988

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Feb 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@aashishc1988, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Please update the PR description to follow the PR template.

@aashishc1988

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

Please update the PR description to follow the PR template.

Done

@cmonr cmonr removed the do not merge label Feb 21, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@aashishc1988 You also need to add a Release Notes section since this is a new feature.

Show resolved Hide resolved tools/device_management.py Outdated
Show resolved Hide resolved tools/device_management.py Outdated

@cmonr cmonr requested a review from theotherjimmy Feb 21, 2019

@aashishc1988

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

@bridadan @theotherjimmy Ready for another review

@bridadan
Copy link
Contributor

left a comment

Good enough for me! Thanks for the changes, be sure to update the release notes section in your description with the new argument!

@@ -51,6 +51,9 @@ def __init__(self, *args, **kwargs):
"Create or transform a manifest. "
"Use {} [command] -h for help on each command."
).format(self.parser.prog)
subparserActionLength = len(self.parser._subparsers._actions)
initParser = self.parser._subparsers._actions[subparserActionLength-1].choices['init']

This comment has been minimized.

Copy link
@bridadan

bridadan Feb 22, 2019

Contributor

Oh we also talked offline about trying to filter based on the type of the subparser action instead of assuming it was at the end of the array, did you have any luck with that?

This comment has been minimized.

Copy link
@cmonr

This comment has been minimized.

Copy link
@aashishc1988

aashishc1988 Feb 25, 2019

Author Contributor

I saw this but unfortunately I wouldnt get around this until later this week as we have some more pressing issues for 5.12 release. Lets keep this PR open, and I will fix this as soon as I can.

needs new review

@0xc0170 0xc0170 added the risk: G label Feb 25, 2019

@bulislaw

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

This PR is at risk of missing 5.12 release as it's marked as "needs: review". Code freeze is coming! On Friday 1st. Please review the changes ASAP.

@theotherjimmy

@aashishc1988

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@theotherjimmy I made some changes to stop assuming SubParser position in the list. Can you review the latest changes?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 27, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@0xc0170 0xc0170 merged commit c123b98 into ARMmbed:master Feb 27, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10473 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.