Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSOC6: send HCI reset after patch RAM download #9821

Merged

Conversation

Projects
None yet
8 participants
@cydriftcloud
Copy link
Contributor

commented Feb 23, 2019

Description

After the patch RAM download is completed, an HCI reset should be sent in order to initialize the registers. Some of the initialization won't be called if the HCI reset is not sent after firmware download.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo

Release Notes

PSOC6: send HCI reset after patch RAM download
After the patch RAM download is completed, a HCI reset should be sent in order to initialize the registers. Some of the initialization won't be called if the HCI reset is not sent after firmware download.

@cydriftcloud cydriftcloud force-pushed the cydriftcloud:send-hci-reset-after-patchram-download branch to a47b365 Feb 23, 2019

@kask01

This comment has been minimized.

Copy link

commented Feb 23, 2019

Changes look fine to me. Thanks.

@NirSonnenschein NirSonnenschein requested review from SeppoTakalo and ARMmbed/mbed-os-maintainers Feb 25, 2019

@pan-

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@cydriftcloud Could you provide more details about what is being solved ?
@NirSonnenschein This PR affects BLE, it would be interesting to asks the @ARMmbed/mbed-os-pan team about it.

@kask01

This comment has been minimized.

Copy link

commented Feb 25, 2019

@pan-
While testing a BT/WiFi coex scenario with BLE in central role, the BLE connections are not sustained in the presence of WiFi. Per the recommendation of our coex team, we are expected to send a HCI reset post firmware download to initialize the BT system. On reviewing the HCIDriver.cpp for 43xxx chips, we observed that this command was missing. The patch addresses that issue. Hope this clarifies.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-pan Feb 25, 2019

@pan-

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@kask01 Thanks, that makes more sense now.

@pan-

pan- approved these changes Feb 25, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Feb 25, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 25, 2019

@cmonr cmonr merged commit 2b811da into ARMmbed:master Feb 25, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10090 cycles (-117 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.