Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 802.15.4 RF drivers to the latest version #9828

Merged
merged 4 commits into from Feb 28, 2019

Conversation

Projects
None yet
8 participants
@artokin
Copy link
Contributor

commented Feb 25, 2019

Description

Update 802.15.4 RF drivers to the latest version for Mbed OS 5.12.

  • Atmel RF driver v3.0.6
  • MCR20a RF driver v1.0.3
  • STM S2LP RF driver v0.0.2

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JarkkoPaso , @SeppoTakalo @mikter

static const phy_rf_channel_configuration_s phy_24ghz = {2405000000U, 5000000U, 250000U, 16U, M_OQPSK};
static const phy_rf_channel_configuration_s phy_subghz = {868300000U, 2000000U, 250000U, 11U, M_OQPSK};
static const phy_rf_channel_configuration_s phy_24ghz = {.channel_0_center_frequency = 2405000000U, .channel_spacing = 5000000U, .datarate = 250000U, .number_of_channels = 16U, .modulation = M_OQPSK};
static const phy_rf_channel_configuration_s phy_subghz = {.channel_0_center_frequency = 868300000U, .channel_spacing = 2000000U, .datarate = 250000U, .number_of_channels = 11U, .modulation = M_OQPSK};

This comment has been minimized.

@artokin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

CI compilation errors happens because new Nanostack API is needed. Nanostack will be published in separate PR.

@ciarmcom ciarmcom requested review from JarkkoPaso, mikter, SeppoTakalo and ARMmbed/mbed-os-maintainers Feb 25, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@artokin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

Requires API changes are available in PR #9838

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

@artokin Mind adding Release Notes?

@artokin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@cmonr , this PR syncs 802.15.4 RF drivers from the master copy. Changes do not require release notes and therefore Release Notes header is now removed.

artokin added some commits Feb 22, 2019

@artokin artokin force-pushed the artokin:update_802154_rf_drivers branch to 05dc1f2 Feb 27, 2019

@artokin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

Rebased to get dependency PR #9838 included to the build.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 27, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@ARMmbed/mbed-os-test Can you review above failure? I can't spot it in the logs (only that nanostack fails to build for M2351 target) . @artokin Please review

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Feb 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

Info: A CI config issue appears to be affecting NUMAKER_PFM_M2351 builds. Please ignore build errors against the target for now.

Other build failures should still be investigated, if any. Will restart CI when appropriate.

@artokin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

I can't find any other build failure than the NUMAKER_PFM_M2351.
NUMAKER_PFM_M2351:ARM seems to fail also in the following builds and therefore it is not related to this PR. Few previous builds were using NUMAKER_PFM_M2351:ARMC6 and then that target was passing.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@artokin wait a second, there's misconfig in CI, will be fixed soon

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 28, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 28, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Test passed but old hook is still present (ARM build job)

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

@0xc0170 fixed

@0xc0170 0xc0170 merged commit 211db10 into ARMmbed:master Feb 28, 2019

30 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10309 cycles (-155 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@artokin artokin deleted the artokin:update_802154_rf_drivers branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.