Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: CGACT not supported in coming firmware in BG96 #9837

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
8 participants
@jarvte
Copy link
Contributor

commented Feb 25, 2019

Description

Fix issue #9749

Fix is to use BG96 proprietary commands instead of CGACT.
API CellularNetwork::is_active_context changed but it takes default values so not marked as Breaking change.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

Release Notes

Change API CellularNetwork::is_active_context to take more parameters to reduce copy-paste code.
API can be use in old way as parameters have default values.
Change CGACT to QIACT in case as BG96 module. Reason is that in upcoming firmware versions only QIACT is supported. Current firmware versions do support both commands.

@ciarmcom ciarmcom requested review from mirelachirica and ARMmbed/mbed-os-maintainers Feb 25, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@jarvte, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

@jarvte Mind adding a Release Notes blurb?

@cmonr

cmonr approved these changes Feb 25, 2019

@cmonr cmonr added the risk: G label Feb 25, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@jarvte Mind adding a Release Notes blurb?

Sure, done.

@AriParkkila
Copy link
Contributor

left a comment

All functions could return nsapi_error_t?
AT clear error should be handled by caller and not deactivate_contexts?

features/cellular/framework/API/CellularNetwork.h Outdated
*
* @return true is any context is active, false otherwise or in case of error
* @param number_of_active_contexts If given then in return contains the number of active contents
* @param cid If given then active contents are checked only against this cid

This comment has been minimized.

Copy link
@mirelachirica

mirelachirica Feb 26, 2019

Contributor

contents -> contexts

This comment has been minimized.

Copy link
@jarvte

jarvte Feb 26, 2019

Author Contributor

fixed

features/cellular/framework/API/CellularNetwork.h Outdated
* @param number_of_active_contexts If given then in return contains the number of active contents
* @param cid If given then active contents are checked only against this cid
*
* @return true is any (or the given cid) context is active, false otherwise or in case of error

This comment has been minimized.

Copy link
@mirelachirica

mirelachirica Feb 26, 2019

Contributor

is -> if

This comment has been minimized.

Copy link
@jarvte

jarvte Feb 26, 2019

Author Contributor

fixed

bool active_found = false;
int context_id;
int active;
// read active contexts

This comment has been minimized.

Copy link
@mirelachirica

mirelachirica Feb 26, 2019

Contributor

Can this "QIACT" part be overritten and rest of the code be in base class since it is so much and is copy pasted?

This comment has been minimized.

Copy link
@jarvte

jarvte Feb 26, 2019

Author Contributor

nice, fixed.

bool active_found = false;
int context_id;
int active;
// read active contexts

This comment was marked as outdated.

Copy link
@mirelachirica

mirelachirica Feb 26, 2019

Contributor

Can this "QIACT" part be overritten and rest of the code be in base class since it is so much and is copy pasted?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Feb 26, 2019

@jarvte jarvte force-pushed the jarvte:drop_bg96_cgact_support branch Feb 26, 2019

features/cellular/framework/AT/AT_CellularNetwork.h Outdated
* same response. Can be overridden by the target class.
*
*/
virtual void set_context_command();

This comment has been minimized.

Copy link
@mirelachirica

mirelachirica Feb 26, 2019

Contributor

would get_context_state_command() be better name and comment:
"... Sends command to query the active state of the PDP contexts... Can be overridden by the target class."

This comment has been minimized.

Copy link
@cmonr

cmonr Feb 27, 2019

Contributor

@jarvte ^^^

This comment has been minimized.

Copy link
@jarvte

jarvte Feb 27, 2019

Author Contributor

fixed as suggested

@bulislaw

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

This PR is at risk of missing 5.12 release as it's marked as "needs: work". Code freeze is coming! On Friday 1st. Please made necessary updates ASAP and make sure the reviewers are aligned for prompt code inspection.

@jarvte jarvte force-pushed the jarvte:drop_bg96_cgact_support branch Feb 27, 2019

@cmonr cmonr added needs: CI and removed needs: work labels Feb 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 27, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

@jarvte Please take a look at the failed unit tests.

@jarvte jarvte force-pushed the jarvte:drop_bg96_cgact_support branch to 4077898 Feb 28, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@jarvte Please take a look at the failed unit tests.

Fixed. It was the last function name change...

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 28, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Can this be postponed to 5.12.1? We got high number of feature PR still opened for 5.12.

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Can this be postponed to 5.12.1? We got high number of feature PR still opened for 5.12.

From my point of view yes. I don't know about the person who wrote the issue #9749

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Thanks ! It might still get in earlier but rather we focus on critical features/fixes now at this stage for 5.12.0

@cmonr cmonr removed the risk: A label Feb 28, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 13, 2019

@0xc0170 0xc0170 merged commit cf76b74 into ARMmbed:master Mar 14, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-52 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10169 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@jarvte jarvte deleted the jarvte:drop_bg96_cgact_support branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.