Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable MPS2 platform #9870

Merged
merged 12 commits into from Apr 17, 2019

Conversation

Projects
None yet
8 participants
@ChangwuShan
Copy link

commented Feb 27, 2019

This pull request is about Re-enable MPS2 platform. It’s continuation of this closed pull request #7694 and add GCC_ARM and IAR support to those targets ( ARM_MPS2_M3, ARM_MPS2_M4 and ARM_MPS2_M7 ).

@ashok-rao

Pull request type

[x] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ashok-rao and ARMmbed/mbed-os-maintainers Feb 27, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@ChangwuShan, thank you for your changes.
@ashok-rao @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Can you share tests results for these targets?

Was this tested with IAR8 ? It's now enabled for master and upcoming 5.12.

@ChangwuShan

This comment has been minimized.

Copy link
Author

commented Feb 28, 2019

Hi @0xc0170, may I ask which kind of test results do you need? I have tested all those targets with the Greentea test and all the tests passed.
I tested the targets with IAR7.5.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

I tested the targets with IAR7.5.

To be on the safe side, we should run IAR8.32 tests as well.

Hi @0xc0170, may I ask which kind of test results do you need? I have tested all those targets with the Greentea test and all the tests passed.

Tests you run, attach the logs here. For any new target (this is reenabled so treated as new target as was disabled for some reason) tests should be part of the PR.

@ChangwuShan

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

Hi @0xc0170 , I got similar problems with this link #7733 when running IAR 8.32. Does Mbed support IAR8.X now?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@ChangwuShan Yes, Mbed OS recently (finally) moved over to IAR 8.32 . Unfortunately, the switch was a hard switch due to some technical challenges.

@cmonr cmonr added needs: review and removed needs: work labels Mar 12, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Changes look fine to me. As we discussed yesterday, M0 build issue should be fixed now, can you also attach M0 test logs?

@ashok-rao Waiting for your review

@ashok-rao

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@ChangwuShan : Thanks for this. Just for completeness, can you please also attach M0 & M0P test logs? Thanks.
@0xc0170 : Changes LGTM! Thanks.

@0xc0170
Copy link
Member

left a comment

Waiting for M0 confirmation all is tested and OK

@ChangwuShan

This comment has been minimized.

Copy link
Author

commented Mar 18, 2019

Hi, test logs for M0:
ARM_MPS2_M0_ARM.txt
ARM_MPS2_M0_GCC_ARM.txt
ARM_MPS2_M0_IAR.txt
There are some timeout issues with M0P (ARMC6, GCC_ARM, IAR) , trying to fix it.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

@ChangwuShan Let us know. You can still enable rest of targets and separate PR for M0P with fixes.

@ChangwuShan ChangwuShan force-pushed the ChangwuShan:Re-enable_MPS2_platform branch from 760d56a to 386f625 Mar 20, 2019

@ChangwuShan

This comment has been minimized.

Copy link
Author

commented Mar 20, 2019

Add GCC_ARM and IAR support for ARM_MPS2_M0P and ARM_MPS2_M0.

@ChangwuShan

This comment has been minimized.

Copy link
Author

commented Mar 21, 2019

@cmonr cmonr requested review from 0xc0170 and cmonr Mar 25, 2019

@cmonr

cmonr approved these changes Mar 27, 2019

@@ -5116,15 +5117,16 @@
"SERIAL",
"SPI",
"SPISLAVE",
"TSC",
"MPU"
"TSC"

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 27, 2019

Contributor

I'm curious. What is TSC?

This comment has been minimized.

Copy link
@ChangwuShan

ChangwuShan Mar 29, 2019

Author

It is Touch Screen. This change is just to delete the "MPU", but I have to delete the comma behind "TSC".

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

CI started

M0 logs provided

ChangwuShan added some commits Jan 29, 2019

Add GCC_ARM support for the target AN382 of MPS2.
Add files MPS2.ld and startup_MPS2.S to support GCC_ARM of the target
AN382(ARM_MPS2_M0). Add "GCC_ARM" to supported_toolchains list.

Change-Id: I7046b698834c82e94015e51eef9a0f5e1315ddaa
Signed-off-by: Shawn Shan <shawn.shan@arm.com>
Add IAR support for the target AN500 of MPS2.
Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target
AN500(ARM_MPS2_M7). Add "IAR" to supported_toolchain list.

Change-Id: I0b8f018fc937727382b27ea0669940ae6675c834
Signed-off-by: Shawn Shan <shawn.shan@arm.com>
Add IAR support for the target AN386 of MPS2.
Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target
AN386(ARM_MPS2_M4). Add "IAR" to supported_toolchain list.

Change-Id: I4f43617c870197b9d39a4d4c9c12456adcc6f96f
Signed-off-by: Shawn Shan <shawn.shan@arm.com>
Add IAR support for the target AN385 of MPS2.
Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target
AN385(ARM_MPS2_M3). Add "IAR" to supported_toolchain list.

Change-Id: I038b05b8b21bd146a1568de897ed030ccd52ab79
Signed-off-by: Shawn Shan <shawn.shan@arm.com>
Add IAR support for the target AN383 of MPS2.
Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target
AN383(ARM_MPS2_M0P). Add "IAR" to supported_toolchain list.

Change-Id: Ib2278d34e265e53ad070aecd318ed4e6a355e3c0
Signed-off-by: Shawn Shan <shawn.shan@arm.com>
Add IAR support for the target AN382 of MPS2.
Add file MPS2.icf and startup_MPS2.S to suppout IAR of the target
AN382(ARM_MPS2_M0). Add "IAR" to supported_toolchain list.

Change-Id: I2b2ad7645166c4f973a8baa9c394521514183767
Signed-off-by: Shawn Shan <shawn.shan@arm.com>
Fix the build failed issue of MPS2 targets with ARMC6.
Change-Id: I0205d381de331a827435d667c16297aaf5bb609e
Signed-off-by: Shawn Shan <shawn.shan@arm.com>

@ChangwuShan ChangwuShan force-pushed the ChangwuShan:Re-enable_MPS2_platform branch from 2c0ea89 to 3d9b7df Apr 15, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted jenkins-ci/greentea-test

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Apr 16, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@ashok-rao Final review please

@ashok-rao
Copy link
Contributor

left a comment

LGTM! Thanks @ChangwuShan

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 16, 2019

@0xc0170 0xc0170 changed the title Re enable mps2 platform Re-enable MPS2 platform Apr 16, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 17, 2019

@0xc0170 0xc0170 merged commit c961a5d into ARMmbed:master Apr 17, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8688 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.