Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP8266: receive is able to handle device busy indication #9871

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
8 participants
@VeijoPesonen
Copy link
Contributor

commented Feb 27, 2019

Description

Socket receive must return NSAPI_ERROR_WOULD_BLOCK if device is busy doing something else, like sending data etc.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@michalpasztamobica
@SeppoTakalo

Release Notes

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@teetak01 for your information

@ciarmcom ciarmcom requested review from michalpasztamobica, SeppoTakalo and ARMmbed/mbed-os-maintainers Feb 27, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@michalpasztamobica
Copy link
Contributor

left a comment

Out of curiosity - have you ever seen the "else" branch entered and DEVICE_ERROR reported?

@VeijoPesonen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

Out of curiosity - have you ever seen the "else" branch entered and DEVICE_ERROR reported?

Noup, but on the other hand I wouldn't have expected that we would hit

MBED_ERROR(MBED_MAKE_ERROR(MBED_MODULE_DRIVER, MBED_ERROR_CODE_ENOMSG), \
neither...

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

This is marked internally as a critical fix so we should try and take it into 5.12

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 28, 2019

@cmonr cmonr merged commit b5878b1 into ARMmbed:master Mar 1, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9109 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 1, 2019

@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:bugfix-esp8266-recv_busy branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.