Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multihoming tests #9875

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
6 participants
@tymoteuszblochmobica
Copy link
Contributor

commented Feb 27, 2019

Description

Fixed test cases for multihoming.
This apply proper network interface instance verify.
It prevents crash if device doesn't have ethernet or wifi device.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo please review
@mikaleppanen please review
@kjbracey-arm please review

Release Notes

@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@SeppoTakalo please review
@mikaleppanen please review
@kjbracey-arm please review

@tymoteuszblochmobica tymoteuszblochmobica changed the title Fix multihoming tests for case of no ethernet device Fix multihoming tests Feb 27, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

I updated Reviewers section (use that one to request reviewers, will be tagged automatically).

@ciarmcom ciarmcom requested review from kjbracey-arm, mikaleppanen, SeppoTakalo and ARMmbed/mbed-os-maintainers Feb 27, 2019

@ciarmcom

This comment has been minimized.

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:testfix branch Feb 27, 2019

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

Should the whole test be flagged with #if DEVICE_EMAC
Because if that is not provided, you don't have proper Ethernet.

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:testfix branch Feb 28, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@tymoteuszblochmobica Can you rebase?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Fixes release tests, marked for 5.12rc1

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@SeppoTakalo Please confirm, this is fixing feature tests, targeting 5.12 rc1

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 4, 2019

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:testfix branch to f420a55 Mar 4, 2019

@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Rebased

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 4, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

starting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170

0xc0170 approved these changes Mar 4, 2019

Copy link
Member

left a comment

I would welcome better fix commit msg, but LGTM otherwise

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 4, 2019

@0xc0170 0xc0170 merged commit 355f09b into ARMmbed:master Mar 4, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10455 cycles (+272 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 4, 2019

@tymoteuszblochmobica tymoteuszblochmobica deleted the tymoteuszblochmobica:testfix branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.