Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock sleep when USB is initialized #9879

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
4 participants
@c1728p9
Copy link
Contributor

commented Feb 27, 2019

Description

Lock sleep when USB is initialized to ensure USB always has a clock lock deep sleep while it is in use. Thanks @rajkan01 for finding this.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@rajkan01

@ciarmcom ciarmcom requested review from rajkan01 and ARMmbed/mbed-os-maintainers Feb 27, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@c1728p9, thank you for your changes.
@rajkan01 @ARMmbed/mbed-os-maintainers please review.

@cmonr

cmonr approved these changes Feb 27, 2019

Lock sleep when USB is initialized
None of the USB drivers currently support entering deep sleep mode
while USB is active. To protect USB from malfunctioning lock deep
sleep in USBPhyHw::init.

@c1728p9 c1728p9 force-pushed the c1728p9:usb_sleep_lock branch to 8ffbe5c Feb 28, 2019

@c1728p9

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Updated this PR to move the locking into vendor specific code. If their hardware supports automatic wake from deep sleep upon reception of USB traffic and software support for this is added then these locks can be removed.

@cmonr

cmonr approved these changes Feb 28, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Feb 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

CI started

@cmonr cmonr added the risk: G label Mar 1, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 1, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 1, 2019

@cmonr cmonr merged commit 3d1b55d into ARMmbed:master Mar 1, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10100 cycles (+900 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 1, 2019

AGlass0fMilk added a commit to AGlass0fMilk/mbed-os that referenced this pull request Mar 15, 2019

Lock sleep when USB is initialized
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR ARMmbed#9879

AGlass0fMilk added a commit to AGlass0fMilk/mbed-os that referenced this pull request Apr 29, 2019

Lock sleep when USB is initialized
Added logic to lock deep sleep when USB is initialized to prevent malfunctioning. This is consistent with the other drivers. See PR ARMmbed#9879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.