Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free dynamic memory in Crypto Service proxy (PSA targets) #9883

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
6 participants
@itayzafrir
Copy link
Contributor

commented Feb 28, 2019

Description

Crypto Service proxy allocated dynamic memory without freeing it in some places.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@avolinski @NirSonnenschein

Release Notes

@0xc0170
Copy link
Member

left a comment

What coding style does crypto follow?

itayzafrir

@itayzafrir itayzafrir force-pushed the itayzafrir:crypto-service-proxy-mem-fix branch to 362c307 Feb 28, 2019

@itayzafrir

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

What coding style does crypto follow?

@0xc0170 Crypto follows mbedtls code style, but this file seems to follow mbed-os style. I've rebased this branch to align with the mbed-os style.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Labeled for 5.12.1 as we are having high number of 5.12 jobs. If this is "a must" in 5.12.0, let us know. It still might get in based on availability.

@itayzafrir

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

I think this is a must, this can lead to substantial memory leaks.

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

@0xc0170 this is potentially serious memory leak affecting PSA crypto IPC based implementations so it would be really good to get this into the 5.12 release if we can.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

CI started

@mikisch81 mikisch81 referenced this pull request Feb 28, 2019

Merged

mbed-SPM updates #9823

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 28, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 28, 2019

@cmonr cmonr merged commit b844395 into ARMmbed:master Mar 1, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9878 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.