Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion of MDMRST in case of SARA-R4 #9902

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
5 participants
@wajahat-ublox
Copy link
Member

commented Mar 1, 2019

Description

In case of SARA-R4, MDMRST needs to be asserted for 10 seconds before modem actually powers down. This means that modem is initially responsive to AT commands but powers down after 10 seconds unless MDMRST is de-asserted (a call to onboard_modem_init() ). This can create confusion for application as CellularDevice::is_ready() will return TRUE initially and ten seconds later modem will power off without any indication to the application.

This can also cause test cases to fail that rely on system_reset() for MCU reboot. In such case, Cellular state machine will get an OK response from CellularDevice::is_ready() so it will not call the power_on() methods and resume its states however after 10 seconds, modem will power down possibly leaving state machine in an undesired state or leading to failure of test case.

We have evaluated others options to fix this problem and have decided not to assert MDMRST in our start-up code. Other options require us to wait 10 seconds at each reset which is not reasonable.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@wajahat-ublox wajahat-ublox changed the title Do not assert MDMRST in case of SARA-R4 Remove assertion of MDMRST in case of SARA-R4 Mar 1, 2019

@ciarmcom ciarmcom requested review from screamerbg and ARMmbed/mbed-os-maintainers Mar 1, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

@wajahat-ublox, thank you for your changes.
@screamerbg @ARMmbed/mbed-os-maintainers please review.

@0xc0170

0xc0170 approved these changes Mar 1, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 13, 2019

@0xc0170 0xc0170 merged commit 1bbf7d6 into ARMmbed:master Mar 14, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-52 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10433 cycles (+1683 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.