Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/cy mbed os 5.12.0 #9908

Merged
merged 8 commits into from Mar 8, 2019

Conversation

@morser499
Copy link

commented Mar 1, 2019

Description

  1. Added CM0+ targets for some Cypress boards
  2. Initial support for Cypress PSA targets
  3. Added flash iap component to Cypress psoc6 m4
  4. Fixed type of STDIO UART initialization variable.
  5. Updated Wiced connectivity libraries to support lower power modes

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@morser499

This comment has been minimized.

Copy link
Author

commented Mar 1, 2019

We believe there is a problem with the following test suite:
Test Suite: features-storage-tests-kvstore-direct_access_devicekey_test
Test: test_direct_access_to_devicekey_tdb_last_two_sectors

Explaination of bug in TDBStore.cpp TDBStore::init():
_master_record_offset is at least 1 sector offset.
_master_record_size takes up at least 2 flash sectors.

When check_erase_before_write occurs, it erases 2 sectors offset by 1 sector.
Hence this code requires at least 3 sectors.
This code attempts to erase beyond the end of flash and causes a hard fault.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

@ARMmbed/mbed-os-storage Please review the above test comment (#9908 (comment))

@cmonr cmonr requested review from ARMmbed/mbed-os-ipcore Mar 1, 2019

@cmonr cmonr added the needs: review label Mar 1, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

@morser499 Do y'all have local test runs for the new targets against the three compilers?

TESTS/mbed_hal/spm/main.cpp Outdated
@@ -23,8 +23,8 @@
#error [NOT_SUPPORTED] this test is supported on GCC only
#endif

#if defined(TARGET_FUTURE_SEQUANA_PSA)
#error [NOT_SUPPORTED] Disable this Test until FUTURE_SEQUANA_PSA enables Memory protection
#if defined(TARGET_FUTURE_SEQUANA_PSA) || defined(TARGET_CY8CKIT_062_WIFI_BT_PSA)

This comment has been minimized.

Copy link
@cmonr

cmonr Mar 1, 2019

Contributor

🎉

This comment has been minimized.

Copy link
@morser499

morser499 Mar 1, 2019

Author

Not yet. Our tests are still running

This comment has been minimized.

Copy link
@orenc17

orenc17 Mar 1, 2019

Contributor

Enable this test please
Your platform has memory separation enabled

This comment has been minimized.

Copy link
@morser499

@cmonr cmonr requested a review from ARMmbed/mbed-os-core Mar 1, 2019

@@ -0,0 +1,123 @@
/* mbed Microcontroller Library
* Copyright (c) 2017-2017 ARM Limited
*

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 2, 2019

Member

SPDX identifier for new files please

This comment has been minimized.

Copy link
@OlegKapshii

OlegKapshii Mar 3, 2019

Contributor

Done.
Fixes to PinNamesTypes.h and PortNames.h files from TARGET_Cypress\TARGET_PSOC6 will be merged to the PR on Monday.

targets/targets.json Outdated
@@ -7965,12 +8019,21 @@
"network-default-interface-type": "WIFI"
}
},
"CYW943012P6EVB_01_M0": {
"inherits": ["MCU_PSOC6_M0"],
"supported_toolchains": ["GCC_ARM", "ARM", "IAR"],

This comment has been minimized.

Copy link
@SenRamakri

SenRamakri Mar 2, 2019

Collaborator

No need to specify supported_toolchains here as the parent MCU_PSOC6 already defines the same toolchain set as here.

This comment has been minimized.

Copy link
@SenRamakri

SenRamakri Mar 4, 2019

Collaborator

Now that we have switched to ARMC6, these entries for supported_toolchains must change.
Cypress targets ares still using ARM compiler 5, and should change all "ARM" entries to "ARMC5" in supported_toolchains. Please make this change for all Cypress targets.

This comment has been minimized.

Copy link
@morser499
targets/targets.json Outdated
"post_binary_hook": {
"function": "PSOC6Code.complete"
}
},
"CYW943012P6EVB_01": {
"inherits": ["MCU_PSOC6_M4"],
"features": ["BLE"],
"supported_toolchains": ["GCC_ARM", "ARM", "IAR"],

This comment has been minimized.

Copy link
@SenRamakri

SenRamakri Mar 2, 2019

Collaborator

No need to specify supported_toolchains here as the parent MCU_PSOC6 already defines the same toolchain set as here.

This comment has been minimized.

Copy link
@morser499
@davidsaada

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

We believe there is a problem with the following test suite:
Test Suite: features-storage-tests-kvstore-direct_access_devicekey_test
Test: test_direct_access_to_devicekey_tdb_last_two_sectors

Explaination of bug in TDBStore.cpp TDBStore::init():
_master_record_offset is at least 1 sector offset.
_master_record_size takes up at least 2 flash sectors.

When check_erase_before_write occurs, it erases 2 sectors offset by 1 sector.
Hence this code requires at least 3 sectors.
This code attempts to erase beyond the end of flash and causes a hard fault.

Can you tell the sector size, page size and the size of the internal flash?

@@ -0,0 +1,23 @@

This comment has been minimized.

Copy link
@orenc17

orenc17 Mar 2, 2019

Contributor

Make this relevant to your target please

This comment has been minimized.

Copy link
@OlegKapshii

OlegKapshii Mar 3, 2019

Contributor

Done.

@@ -0,0 +1,36 @@
# Copyright (c) 2017-2018 ARM Limited

This comment has been minimized.

Copy link
@orenc17

orenc17 Mar 2, 2019

Contributor

Not needed anymore, targets.json defines a delivery_dir

This comment has been minimized.

Copy link
@OlegKapshii

OlegKapshii Mar 3, 2019

Contributor

The file removed

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 2, 2019

Please also attach test results for all 3 toolchains (as this is new target addition)

@morser499 morser499 force-pushed the morser499:pr/cy-mbed-os-5.12.0 branch Mar 2, 2019

@morser499

This comment has been minimized.

Copy link
Author

commented Mar 2, 2019

We are observing a compilation failure with COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.c under IAR. Other toolchains work fine.

Compile: C:/Program Files (x86)/IAR Systems/Embedded Workbench 8.0/arm\bin\iccarm --no_wrap_diagnostics -e --diag_suppress=Pa050,Pa084,Pa093,Pa082 -Oh --enable_restrict -DMBED_TRAP_ERRORS_ENABLED=1 --cpu Cortex-M0+ --thumb --dlib_config DLib_Config_Full.h --vla --diag_suppress=Pe546 -DTARGET_CY8CKIT_062_WIFI_BT_M0 -DTARGET_PSA -DMBEDTLS_PSA_CRYPTO_SPM -DTARGET_PSA_Target -D__MBED__=1 -DTARGET_LIKE_MBED -DDEVICE_PORTINOUT=1 -D__MBED_CMSIS_RTOS_CM -DTARGET_NAME=CY8CKIT_062_WIFI_BT_M0_PSA -DCOMPONENT_FLASHIAP=1 -DDEVICE_RTC=1 -DDEVICE_SERIAL_ASYNCH=1 -D__CMSIS_RTOS -DMBED_MPU_CUSTOM -DCY8C6247BZI_D54 -DTARGET_SPE_Target -DDEVICE_USTICKER=1 -DDEVICE_I2C=1 -DDEVICE_CRC=1 -DTARGET_CORTEX_M -DTARGET_M0P -DDEVICE_ANALOGOUT=1 -DTARGET_PSOC6 -DMBEDTLS_ENTROPY_NV_SEED -DMBED_BUILD_TIMESTAMP=1551454731.09 -DMCU_PSOC6_M0 -DDEVICE_LPTICKER=1 -DTOOLCHAIN_IAR -DPSOC6_DYNSRM_DISABLE=1 -DCOMPONENT_SPE=1 -DMBED_TICKLESS -DDEVICE_INTERRUPTIN=1 -DTARGET_MCU_PSOC6_M0 -DCOMPONENT_PSA_SRV_IMPL=1 -DTARGET_CORTEX -DTARGET_CY8CKIT_062_WIFI_BT_M0_PSA -DDEVICE_PORTOUT=1 -D__CORTEX_M0PLUS -DDEVICE_STDIO_MESSAGES=1 -DDEVICE_PWMOUT=1 -DDEVICE_SPI_ASYNCH=1 -DTARGET_CY8C62XX -DTARGET_FF_ARDUINO -DTARGET_RELEASE -DCY_IPC_DEFAULT_CFG_DISABLE -DDEVICE_SERIAL_FC=1 -DTARGET_CY8CKIT_062_WIFI_BT -DMBEDTLS_PSA_CRYPTO_C -DDEVICE_TRNG=1 -DARM_MATH_CM0PLUS -DDEVICE_PORTIN=1 -DDEVICE_SLEEP=1 -DTARGET_MCU_PSOC6 -DCOMPONENT_PSA_SRV_IPC=1 -DDEVICE_SPI=1 -DTARGET_MBED_SPM -DTARGET_Cypress -DDEVICE_ANALOGIN=1 -DDEVICE_SERIAL=1 -DDEVICE_FLASH=1 -DDEVICE_I2C_ASYNCH=1 -DCOMPONENT_SPM_MAILBOX=1 -DTARGET_LIKE_CORTEX_M0 -f .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR.includes_70d6569d1107ac5e98f019d4cdd3dc01.txt --preinclude=.\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\mbed_config.h --dependencies BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.d -l BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.s.txt -o BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.o .\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.c
[DEBUG] Return: 0
[DEBUG] Output: Warning[Ms014]: some characters could not be correctly encoded in "C:\Users\ohks\Projects\mbed-os\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.s.txt", and have been replaced with '@'. The first such character has unicode code point 0x20ac ("€")
'ascii' codec can't decode byte 0xe2 in position 343: ordinal not in range(128)
Failed to build library
Memory map breakdown for built projects (values in Bytes):
| name | target | toolchain | static_ram | total_flash |
|------|--------|-----------|------------|-------------|
Traceback (most recent call last):
File "C:\Users\ohks\Projects\mbed-os\tools\test.py", line 296, in
status = print_report_exporter.report(build_report)
File "C:\Users\ohks\Projects\mbed-os\tools\test_exporters.py", line 92, in report
return self.exporter_print(test_summary_ext, print_log_for_failures=print_log_for_failures)
File "C:\Users\ohks\Projects\mbed-os\tools\test_exporters.py", line 345, in exporter_print
raise Exception("'test_run' did not have a 'result' value")
Exception: 'test_run' did not have a 'result' value
[ERROR] 'test_run' did not have a 'result' value
[mbed] Working path "C:\Users\ohks\Projects\mbed-os" (program)
[mbed] Exec "C:\Python27\python.exe -u C:\Users\ohks\Projects\mbed-os\tools\test.py -t IAR -m CY8CKIT_062_WIFI_BT_M0_PSA --source . --build .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR --test-spec .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\test_spec.json --build-data .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\build_data.json -n psa- -v --greentea" in "C:\Users\ohks\Projects\mbed-os"

@morser499

This comment has been minimized.

Copy link
Author

commented Mar 2, 2019

We believe there is a problem with the following test suite:
Test Suite: features-storage-tests-kvstore-direct_access_devicekey_test
Test: test_direct_access_to_devicekey_tdb_last_two_sectors
Explaination of bug in TDBStore.cpp TDBStore::init():
_master_record_offset is at least 1 sector offset.
_master_record_size takes up at least 2 flash sectors.
When check_erase_before_write occurs, it erases 2 sectors offset by 1 sector.
Hence this code requires at least 3 sectors.
This code attempts to erase beyond the end of flash and causes a hard fault.

Can you tell the sector size, page size and the size of the internal flash?

Flash Size = 1M
Sector Size = 512b
Page Size = 512b

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

We are observing a compilation failure with COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.c under IAR. Other toolchains work fine.

@mikisch81 @orenc17 Please review

@morser499 morser499 force-pushed the morser499:pr/cy-mbed-os-5.12.0 branch Mar 3, 2019

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

We are observing a compilation failure with COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.c under IAR. Other toolchains work fine.

Compile: C:/Program Files (x86)/IAR Systems/Embedded Workbench 8.0/arm\bin\iccarm --no_wrap_diagnostics -e --diag_suppress=Pa050,Pa084,Pa093,Pa082 -Oh --enable_restrict -DMBED_TRAP_ERRORS_ENABLED=1 --cpu Cortex-M0+ --thumb --dlib_config DLib_Config_Full.h --vla --diag_suppress=Pe546 -DTARGET_CY8CKIT_062_WIFI_BT_M0 -DTARGET_PSA -DMBEDTLS_PSA_CRYPTO_SPM -DTARGET_PSA_Target -D__MBED__=1 -DTARGET_LIKE_MBED -DDEVICE_PORTINOUT=1 -D__MBED_CMSIS_RTOS_CM -DTARGET_NAME=CY8CKIT_062_WIFI_BT_M0_PSA -DCOMPONENT_FLASHIAP=1 -DDEVICE_RTC=1 -DDEVICE_SERIAL_ASYNCH=1 -D__CMSIS_RTOS -DMBED_MPU_CUSTOM -DCY8C6247BZI_D54 -DTARGET_SPE_Target -DDEVICE_USTICKER=1 -DDEVICE_I2C=1 -DDEVICE_CRC=1 -DTARGET_CORTEX_M -DTARGET_M0P -DDEVICE_ANALOGOUT=1 -DTARGET_PSOC6 -DMBEDTLS_ENTROPY_NV_SEED -DMBED_BUILD_TIMESTAMP=1551454731.09 -DMCU_PSOC6_M0 -DDEVICE_LPTICKER=1 -DTOOLCHAIN_IAR -DPSOC6_DYNSRM_DISABLE=1 -DCOMPONENT_SPE=1 -DMBED_TICKLESS -DDEVICE_INTERRUPTIN=1 -DTARGET_MCU_PSOC6_M0 -DCOMPONENT_PSA_SRV_IMPL=1 -DTARGET_CORTEX -DTARGET_CY8CKIT_062_WIFI_BT_M0_PSA -DDEVICE_PORTOUT=1 -D__CORTEX_M0PLUS -DDEVICE_STDIO_MESSAGES=1 -DDEVICE_PWMOUT=1 -DDEVICE_SPI_ASYNCH=1 -DTARGET_CY8C62XX -DTARGET_FF_ARDUINO -DTARGET_RELEASE -DCY_IPC_DEFAULT_CFG_DISABLE -DDEVICE_SERIAL_FC=1 -DTARGET_CY8CKIT_062_WIFI_BT -DMBEDTLS_PSA_CRYPTO_C -DDEVICE_TRNG=1 -DARM_MATH_CM0PLUS -DDEVICE_PORTIN=1 -DDEVICE_SLEEP=1 -DTARGET_MCU_PSOC6 -DCOMPONENT_PSA_SRV_IPC=1 -DDEVICE_SPI=1 -DTARGET_MBED_SPM -DTARGET_Cypress -DDEVICE_ANALOGIN=1 -DDEVICE_SERIAL=1 -DDEVICE_FLASH=1 -DDEVICE_I2C_ASYNCH=1 -DCOMPONENT_SPM_MAILBOX=1 -DTARGET_LIKE_CORTEX_M0 -f .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR.includes_70d6569d1107ac5e98f019d4cdd3dc01.txt --preinclude=.\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\mbed_config.h --dependencies BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.d -l BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.s.txt -o BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.o .\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.c
[DEBUG] Return: 0
[DEBUG] Output: Warning[Ms014]: some characters could not be correctly encoded in "C:\Users\ohks\Projects\mbed-os\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\components\TARGET_PSA\services\attestation\COMPONENT_PSA_SRV_IMPL\tfm_impl\attest_token.s.txt", and have been replaced with '@'. The first such character has unicode code point 0x20ac ("€")
'ascii' codec can't decode byte 0xe2 in position 343: ordinal not in range(128)
Failed to build library
Memory map breakdown for built projects (values in Bytes):
| name | target | toolchain | static_ram | total_flash |
|------|--------|-----------|------------|-------------|
Traceback (most recent call last):
File "C:\Users\ohks\Projects\mbed-os\tools\test.py", line 296, in
status = print_report_exporter.report(build_report)
File "C:\Users\ohks\Projects\mbed-os\tools\test_exporters.py", line 92, in report
return self.exporter_print(test_summary_ext, print_log_for_failures=print_log_for_failures)
File "C:\Users\ohks\Projects\mbed-os\tools\test_exporters.py", line 345, in exporter_print
raise Exception("'test_run' did not have a 'result' value")
Exception: 'test_run' did not have a 'result' value
[ERROR] 'test_run' did not have a 'result' value
[mbed] Working path "C:\Users\ohks\Projects\mbed-os" (program)
[mbed] Exec "C:\Python27\python.exe -u C:\Users\ohks\Projects\mbed-os\tools\test.py -t IAR -m CY8CKIT_062_WIFI_BT_M0_PSA --source . --build .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR --test-spec .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\test_spec.json --build-data .\BUILD\tests\CY8CKIT_062_WIFI_BT_M0_PSA\IAR\build_data.json -n psa- -v --greentea" in "C:\Users\ohks\Projects\mbed-os"

@moranpeker

@davidsaada

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

We believe there is a problem with the following test suite:
Test Suite: features-storage-tests-kvstore-direct_access_devicekey_test
Test: test_direct_access_to_devicekey_tdb_last_two_sectors
Explaination of bug in TDBStore.cpp TDBStore::init():
_master_record_offset is at least 1 sector offset.
_master_record_size takes up at least 2 flash sectors.
When check_erase_before_write occurs, it erases 2 sectors offset by 1 sector.
Hence this code requires at least 3 sectors.
This code attempts to erase beyond the end of flash and causes a hard fault.

Can you tell the sector size, page size and the size of the internal flash?

Flash Size = 1M
Sector Size = 512b
Page Size = 512b

Thank you. In this case (page size equal to sector size), it's a known problem in that test, which we plan to have a PR fixing it today or tomorrow.

@yossi2le

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

I am trying to compile the mbed-os bootloader for the CY8CKIT_062_WIFI_BT and CY8CKIT_062_BLE boards and currently I found out that the following code at gpio_init is calling RTOS:

`
/* Ignore pin reservation result because there is not possibility to release
* reserved HW resource. The MBED does not provide proper destructors for
* doing that.
*/

if (!(IsIrqMode() || IsIrqMasked())) {
    (void) cy_reserve_io_pin(pin);
}

`

Is there any possibility to overcome this issue? Cause compiling RTOS will have a significant impact on code size.

@morser499 morser499 force-pushed the morser499:pr/cy-mbed-os-5.12.0 branch to 4c1ff13 Mar 7, 2019

@morser499

This comment has been minimized.

Copy link
Author

commented Mar 7, 2019

just to make sure we are aligned please follow these steps:

1. rebase on latest master & cherry pick #9978

2. run `tools/psa/release.py -m <YOUR-M0-CORE-PSA-TARGET>`

3. commit the new secure binaires

4. supply test result for the following filter *psa*,*mbed-crypto*,*spm*

The changes have been made and added to the PR. We are in the process of running the updated tests and will post them as soon as they finish.

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@morser499 any updates wrt PSA test results?

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@cmonr can it go to CI?

@morser499

This comment has been minimized.

Copy link
Author

commented Mar 7, 2019

I have results for IAR; the other toolchains are still running

CY8CKIT_062_WIFI_BT__PSA__IAR.txt

@volodymyrbotsian

This comment has been minimized.

Copy link

commented Mar 7, 2019

Results for psa,mbed-crypto,spm on IAR
CY8CKIT_062_WIFI_BT_PSA__PSA__IAR.log

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@volodymyrbotsian could you try running the failed test again? seems like a flashing issue
components-target_psa-tests-compliance_crypto-test_c035

@volodymyrbotsian

This comment has been minimized.

Copy link

commented Mar 7, 2019

@orenc17 sure, I'll rerun

@volodymyrbotsian

This comment has been minimized.

Copy link

commented Mar 7, 2019

Results for psa,mbed-crypto,spm on ARM
CY8CKIT_062_WIFI_BT_PSA__PSA__ARM.log

@morser499

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

Attached are the log files for all 3 runs. NOTE: This includes the re-run IAR test which is still showing the same timeout failure.

CY8CKIT_062_WIFI_BT_PSA__PSA__ARM.log
CY8CKIT_062_WIFI_BT_PSA__PSA__GCC_ARM.log
CY8CKIT_062_WIFI_BT_PSA__PSA__IAR.log

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

@cmonr can it go to CI?

Will start CI to see where this is at whilst the last test is sorted out.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 8, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added needs: review and removed needs: work labels Mar 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Waiting for approvals

@0xc0170

0xc0170 approved these changes Mar 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Attached are the log files for all 3 runs. NOTE: This includes the re-run IAR test which is still showing the same timeout failure.

@orenc17 @mikisch81 I marked this as ready for merge but would like to know what are these timeouts in the tests. Would these block this PRs - suggestions?

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Attached are the log files for all 3 runs. NOTE: This includes the re-run IAR test which is still showing the same timeout failure.

@orenc17 @mikisch81 I marked this as ready for merge but would like to know what are these timeouts in the tests. Would these block this PRs - suggestions?

@alzix
There is 1 test timeout only in IAR and may be related to small timeout value, as all the PSA teams not in office today we can't do manual checks.
I suggest not to block.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

It can be addressed on Sunday, would be good to create a tracking issue.

Ready for integration now

@0xc0170 0xc0170 merged commit 820a2e2 into ARMmbed:master Mar 8, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9241 cycles (-963 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 8, 2019

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

It can be addressed on Sunday, would be good to create a tracking issue.

Ready for integration now

Thanks!

Can you open a jira ticket for us? (Not near PC right now)

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Done, #10007

@morser499 morser499 deleted the morser499:pr/cy-mbed-os-5.12.0 branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.