Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in crypto_acl test #9913

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
5 participants
@orenc17
Copy link
Contributor

commented Mar 3, 2019

Description

Send correct signature buffer size to psa_asymmetric_verify() in test

This PR is required for #9908 & #9910

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@itayzafrir

Release Notes

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

critical test fix for Cypress and other MBED-SPM targets. starting CI

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170

0xc0170 approved these changes Mar 3, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Send correct signature buffer size to psa_asymmetric_verify() in test

This should be in the commit msg !

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

As this is required by #9913 and it's a fix, LGTM

@0xc0170 0xc0170 merged commit fa65546 into ARMmbed:master Mar 3, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9808 cycles (+189 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 requested a review from ChiefBureaucraticOfficer Mar 3, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

Send correct signature buffer size to psa_asymmetric_verify() in test

This should be in the commit msg !

@0xc0170
Sorry, I'll do my best in the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.