Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #ifndef NO_GREENTEA from tests #9914

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
9 participants
@orenc17
Copy link
Contributor

commented Mar 3, 2019

Description

Remove #ifndef NO_GREENTEA from PSA tests as #9835 was merged

wait for #9823

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa @ARMmbed/mbed-os-maintainers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 3, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

@orenc17 orenc17 force-pushed the kfnta:remove_no_greentea branch Mar 3, 2019

@NirSonnenschein
Copy link
Contributor

left a comment

LGTM

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

@ARMmbed/mbed-os-maintainers review is done, can we get this merged?

@jamesbeyond

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Hey @orenc17, I got a question here, if wen have NO_GREENTEA defined in greentea_test_env.cpp, why do we still need this in each test?

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

@jamesbeyond This PR REMOVES all the excess defines from the tests

@jamesbeyond

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Sorry, I was mistaken this PR as adding them. one thing to mention, maybe that Macro should be called NO_GREENTEA_SYNC which is more make sense

@jamesbeyond
Copy link
Contributor

left a comment

Looks good!

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

review is done, can we get this merged?

Sure, but at the moment, this is marked for 5.12.1. Until RC1 is generated, and the 5.12 branch made, we can't merge 5.12.1 PRs.

This could come into 5.12.1, but that would require an ACK from @ChiefBureaucraticOfficer

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 6, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 6, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@orenc17 quick question - is this still up to date (been few days on hold due to 5.12rcs). If yes, can go in

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

I'll rebase and verify

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Mar 14, 2019

@orenc17 orenc17 force-pushed the kfnta:remove_no_greentea branch to fc97a75 Mar 14, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@0xc0170 rebased and removed another usage of #ifdef NO_GREENTEA from PSA compliance tests

ready for CI

@cmonr cmonr added needs: CI and removed needs: work labels Mar 15, 2019

@0xc0170 0xc0170 added the rollup PR label Mar 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

No more changes are expected there.

This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit fc97a75 into ARMmbed:master Mar 15, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9377 cycles (-865 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.