Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML21J18A: #endif without #if in analogout_api.c #9925

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
5 participants
@janjongboom
Copy link
Contributor

commented Mar 4, 2019

This PR: 3bd3aca#diff-995cd6fe18f4fabfb549266dde0a3784 broke the SAML21J18A target, as there was no #if DEVICE_ANALOGOUT call, and this PR added an #endif there that's not matched now.

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

SAML21J18A: #endif without #if in analogout_api.c
This PR: 3bd3aca#diff-995cd6fe18f4fabfb549266dde0a3784 broke the SAML21J18A target, as there was no `#if DEVICE_ANALOGOUT` call, and this PR added an `#endif` there that's not matched now.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Mar 4, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@janjongboom, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170

0xc0170 approved these changes Mar 4, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@c1728p9

c1728p9 approved these changes Mar 4, 2019

Copy link
Contributor

left a comment

Thanks for the fix @janjongboom

@janjongboom

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@c1728p9 @0xc0170 cppcheck actually caught this as well. Maybe we should start using it more:

[targets/TARGET_Atmel/TARGET_SAM_CortexM0P/TARGET_SAML21J18A/analogout_api.c:122]: (error) #endif without #if
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@janjongboom How long did it take to run cppcheck on the entire codebase? 😀

@janjongboom

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@cmonr Not that long, maybe 15 minutes. But I found quite a lot of stuff through it already (even without configuring any macros / build options).

@0xc0170 0xc0170 added the rollup PR label Mar 14, 2019

@0xc0170 0xc0170 referenced this pull request Mar 14, 2019

Merged

Rollup PRs: simple fixes #10097

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

No more changes are expected there.

This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit 67b706a into ARMmbed:master Mar 15, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9003 cycles (-1180 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.