Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased timeout for lwip waiting netif_is_link_up #9935

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
6 participants
@jarvte
Copy link
Contributor

commented Mar 5, 2019

Description

Cellular PPP connect fails too often if timeout is 15s so increased to 60 seconds.
Tested to be enough with BG96 and MTB_MTS_DRAGONFLY.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Increased timeout for lwip waiting netif_is_link_up
Cellular PPP connect fails too often if timeout is 15s so increased to 60 seconds.
Tested to be enough with BG96 and MTB_MTS_DRAGONFLY.
@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

Seems like failure not related to this pr.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@jarvte, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Travis restarted

@cmonr

cmonr approved these changes Mar 5, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 16, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 16, 2019

Merge pull request ARMmbed#9935 from jarvte/lwip_timeout_bringup_link
Increased timeout for lwip waiting netif_is_link_up

@cmonr cmonr merged commit e697d37 into ARMmbed:master Mar 17, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9139 cycles (-1392 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 17, 2019

@jarvte jarvte deleted the jarvte:lwip_timeout_bringup_link branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.