Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: removed manual registering state. #9937

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
6 participants
@jarvte
Copy link
Contributor

commented Mar 5, 2019

Description

Simplified state machine by removing manual registering state. This was done as some modems did not have all the needed at commands for checking the registered network. Some modem run out of memory as when checking correct network there might be so many networks available. Manual registration still works but it does not do any checks to which network it's registered. Moved manual registering at command earlier in state machine so it forces registering to a correct network. Internal fix, does not affect applications or change behavior outside.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Release Notes

Cellular: removed manual registering state.
Simplified state machine by removing manual registering state.
This was done as some modems did not have all the needed at commands
for checking the registered network. Some modem run out of memory as when
checking correct network there might be so many networks available.
Manual registration still works but it does not do any checks to which network
it's registered. Moved manual registering at command earlier in state machine so it forces
registering to a correct network. Internal refactor/fix, does not affect applications.

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Mar 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-wan Mar 5, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

Seems like failure not related to this pr.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Travis astyle job restarted

@0xc0170

0xc0170 approved these changes Mar 8, 2019

Copy link
Member

left a comment

Is this a fix backwards compatible?

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 8, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Is this a fix backwards compatible?

@0xc0170 Yes, internal state machine fixes.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

No more changes are expected there.

This was added to the rollup PR #10116 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit a830dbf into ARMmbed:master Mar 15, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9123 cycles (-1408 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019

@jarvte jarvte deleted the jarvte:plmn_stm_fix2 branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.