Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing RSPIF component to the defaut BlockDevice handler #9941

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
6 participants
@marcuschangarm
Copy link
Contributor

commented Mar 5, 2019

Description

Add missing support for RSPIF when using BlockDevice::get_default_instance().

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@marcuschangarm, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@dannybenor
Copy link

left a comment

For which target do you want to define rspif as default?

@marcuschangarm

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

When compiling the bootloader.

@dannybenor

This comment has been minimized.

Copy link

commented Mar 6, 2019

I think this code will better fit the bootloader than a central place. If we will not have the special components in targets.json, it is better to allocate according to the real parallel component. If spif then the bootloader will allocate rspif.

@marcuschangarm

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Wouldn't that be an anti-pattern for the user experience, though?

Right now we teach our users to set the default blockdevice using the configurations system. It works for all blockdevices in components, except this one.

@dannybenor

This comment has been minimized.

Copy link

commented Mar 6, 2019

Bootloader is not intended to be built by users. They should use a ready made binary

@marcuschangarm

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@dannybenor I've sent you a message on Slack.

@cmonr

cmonr approved these changes Mar 6, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 15, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 15, 2019

@0xc0170 0xc0170 merged commit 78a3d99 into ARMmbed:master Mar 15, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10621 cycles (+391 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.