Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined tr_debug for QUECTEL_BG96 cellular feature #9965

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
6 participants
@sarahmarshy
Copy link
Contributor

commented Mar 6, 2019

Description

Define tr_debug function in QUECTEL_BG96 cellular feature

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 7, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@sarahmarshy, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96.cpp Outdated
@@ -30,6 +30,8 @@ using namespace events;

#define DEVICE_READY_URC "CPIN:"

#define tr_debug(...)

This comment has been minimized.

Copy link
@jarvte

jarvte Mar 7, 2019

Contributor

Please remove this and include the correct header:
#include "CellularLog.h"

This comment has been minimized.

Copy link
@jupe

jupe Mar 9, 2019

Contributor

Just curious, for what purpose CellularLog is? can’t mbed_trace include be used directly here?

This comment has been minimized.

Copy link
@jarvte

jarvte Mar 11, 2019

Contributor

It defines trace group. There was other reasons in older mbed-os versions.

@cmonr cmonr added needs: work and removed needs: review labels Mar 7, 2019

@sarahmarshy sarahmarshy force-pushed the sarahmarshy:tr-debug-cell branch Mar 8, 2019

@sarahmarshy sarahmarshy force-pushed the sarahmarshy:tr-debug-cell branch to ae45096 Mar 8, 2019

@sarahmarshy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@jarvte @cmonr Fixed now.

@jarvte

jarvte approved these changes Mar 9, 2019

@0xc0170 0xc0170 added the rollup PR label Mar 14, 2019

@0xc0170 0xc0170 referenced this pull request Mar 14, 2019

Merged

Rollup PRs: simple fixes #10097

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

No more changes are expected there.

This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately.

@0xc0170 0xc0170 merged commit ae45096 into ARMmbed:master Mar 15, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9873 cycles (-28 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.