Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-M config: Add max_ns_thread_count parameter #9973

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
7 participants
@mikisch81
Copy link
Contributor

commented Mar 7, 2019

Description

#9931 reduced number of threads in block device test from 5 to 4 due to errors in TF-M targets.
The root cause of the error was the fact that TF-M had a fixed maximum number of non-secure thread allowed (defined by the TFM_MAX_NS_THREAD_COUNT in tfm_nspm.c).

This PR add a configuration parametr for this macro in mbed_lib.json and returns the number of the test to 5.

Tests results on LPC55S69:

| target            | platform_name | test suite                                                      | result | elapsed_time (sec) | copy_method |
|-------------------|---------------|-----------------------------------------------------------------|--------|--------------------|-------------|
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | OK     | 23.79              | default     |
mbedgt: test suite results: 1 OK
mbedgt: test case report:
| target            | platform_name | test suite                                                      | test case                                         | passed | failed | result | elapsed_time (sec) |
|-------------------|---------------|-----------------------------------------------------------------|---------------------------------------------------|--------|--------|--------|--------------------|
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | DEFAULT Testing get type functionality            | 1      | 0      | OK     | 0.11               |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing BlockDevice erase functionality  | 1      | 0      | OK     | 0.4                |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing Deinit block device              | 1      | 0      | OK     | 0.09               |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing Init block device                | 1      | 0      | OK     | 0.1                |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing contiguous erase, write and read | 1      | 0      | OK     | 0.12               |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing multi threads erase program read | 1      | 0      | OK     | 1.3                |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing program read small data sizes    | 1      | 0      | OK     | 0.13               |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing read write random blocks         | 1      | 0      | OK     | 0.45               |
| LPC55S69_NS-ARMC6 | LPC55S69_NS   | mbed-os-features-storage-tests-blockdevice-general_block_device | FLASHIAP Testing unaligned erase blocks           | 1      | 0      | OK     | 0.12               |
mbedgt: test case results: 9 OK
mbedgt: completed in 24.03 sec

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@orenc17 @offirko

Release Notes

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

targeting 5.12.0 or later?

@mikisch81

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

targeting 5.12.0 or later?

5.12.0-rc2

@orenc17

orenc17 approved these changes Mar 7, 2019

@offirko

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@offirko

offirko approved these changes Mar 7, 2019

Copy link
Contributor

left a comment

LGTM

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 7, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 7, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr

cmonr approved these changes Mar 7, 2019

@cmonr cmonr merged commit ff78bc4 into ARMmbed:master Mar 7, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10129 cycles (-48 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.