Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for and Recompute sector information for all targets #9989

Merged
merged 4 commits into from Mar 8, 2019

Conversation

Projects
None yet
6 participants
@theotherjimmy
Copy link
Contributor

commented Mar 7, 2019

Description

The use cmsis-pack-manager PR did not include these in the index because
they failed to download when I last did the index update.

This PR adds a test for sector information, and recomputes all missing
sector information so that the test passes (in that order).

Note: This was marked as a blocker bug, so I expect to see it in
5.12.0-rcX for some X.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@cmonr

cmonr approved these changes Mar 7, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

@JanneKiiskila @jenia81 Mind verifying that this fixes the sector issue?

Fixes https://jira.arm.com/browse/IOTCORE-1087

@cmonr cmonr requested review from jenia81 and JanneKiiskila Mar 7, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

CI started whilst final reviews come in

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 7, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@ChiefBureaucraticOfficer
Copy link

left a comment

Meets criteria, fix for 5.12 feature. Approved.

@jenia81

This comment has been minimized.

Copy link

commented Mar 7, 2019

@0xc0170

0xc0170 approved these changes Mar 8, 2019

@0xc0170 0xc0170 merged commit d97902b into ARMmbed:master Mar 8, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9052 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.