Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct FPU settings traceback found by IAR #9994

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
5 participants
@theotherjimmy
Copy link
Contributor

commented Mar 7, 2019

Description

Fixes #9974

The error was that the Asymmetric CPUs were assumed to have the same
structure as the Symmetric CPUs. This is clearly false.

This PR changes the FPU detection of Asymmetric CPUs to find the correct
core and use it's cpu settings.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-iar-dfpu branch Mar 7, 2019

Correct FPU settings traceback found by IAR
Fixes #9974

The error was that the Asymmetric CPUs were assumed to have the same
structure as the Symmetric CPUs. This is clearly false.

This PR changes the FPU detection of Asymmetric CPUs to find the correct
core and use it's cpu settings.

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-iar-dfpu branch to 35479e8 Mar 7, 2019

@cmonr

cmonr approved these changes Mar 7, 2019

@0xc0170

0xc0170 approved these changes Mar 8, 2019

@mikisch81

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

@ARMmbed/mbed-os-maintainers Is it possible to move this to rc3, now that #10068 needs it?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@ARMmbed/mbed-os-maintainers Is it possible to move this to rc3, now that #10068 needs it?

release request done, will wait for approval

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 13, 2019

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

No failures in the build artifacts. @0xc0170 What went wrong?

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Woah.

java.io.IOException: Server returned HTTP response code: 502 for URL: https://api.github.com/repos/ARMmbed/mbed-os/statuses/35479e8111ea1000b81d080e8784a3c8d32684b9
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1894)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:347)
	at org.kohsuke.github.Requester.parse(Requester.java:607)

This was inside of the job itself.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

CI restarted.

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 13, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

armclang: error: Failed to check out a license.

Restarted the export job...

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 14, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@theotherjimmy TODO in the code, can we have this rather as an issue?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

As this fixes exporters on nightly on 5.12

LGTM

@0xc0170 0xc0170 merged commit 4c7fc65 into ARMmbed:master Mar 14, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9134 cycles (-1070 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details
@theotherjimmy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

I can open an issue for it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.