Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing path comparisons in config tests on Windows #9995

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
8 participants
@bridadan
Copy link
Contributor

commented Mar 7, 2019

Description

The config tests compare some paths to be sure the requires keyword is working correctly. However, on Windows, paths are separated with \ instead of /. This PR normalizes the paths to be consistent before comparing them.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@bridadan bridadan requested a review from theotherjimmy Mar 7, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 7, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 11, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

Needs rebase (test will fail, started it before I noticed the conflict)

@cmonr cmonr added needs: work and removed needs: CI labels Mar 16, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@bridadan Can you rebase this please?

@bridadan bridadan force-pushed the bridadan:fix_config_tests_on_windows branch from ed2c2f5 to 51c1bd3 Mar 27, 2019

@bridadan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

Done!

@cmonr cmonr added needs: CI and removed needs: work labels Mar 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 28, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

restarted exporter

@cmonr cmonr added ready for merge and removed needs: CI labels Mar 28, 2019

cmonr added a commit to cmonr/mbed-os that referenced this pull request Mar 28, 2019

Merge pull request ARMmbed#9995 from bridadan/fix_config_tests_on_win…
…dows

Fixing path comparisons in config tests on Windows

@cmonr cmonr merged commit 775a91d into ARMmbed:master Mar 28, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9251 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.