-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target.requires breaks configuration #162
Comments
Note to self so I remember to restart CI when fixed: |
Thanks for raising this. We had a fix go in for |
Apparently the old tools allowed a user to specify a required lib in the "target_overrides" section of the config, even if no root "requires" are defined. This commit adds support for this workflow. Fixes ARMmbed#162
Apparently the old tools allowed a user to specify a required lib in the "target_overrides" section of the config, even if no root "requires" are defined. This commit adds support for this workflow. Fixes ARMmbed#162
Apparently the old tools allowed a user to specify a required lib in the "target_overrides" section of the config, even if no root "requires" are defined. This commit adds support for this workflow. Fixes #162
Hi, this still does't work, although the error output is different:
|
You can check on ARMmbed/mbed-os-example-ble#349
|
Thanks Paul. I'll take another look :/ |
Is |
The baremetal-blinky example also uses Then bare_metal/mbed_lib.json Looks like we need a similar requires chain for this ble example. |
yeah, the requires in the root works but the problem with using that one is that it overrides all the deafult mbed-os requires, so it compiles the experimental libraries but not mbed-os itself, the way requires works is wholly unintuitive |
basically, to use the root version of requiers I would need a way to have it add, rather than replace, so something like requires_add |
Just to ensure I'm following here: are you saying that Is the |
If I just delete The new CMake stuff pulls them in, too. You have an Here's the memory map output from the old tool using
and without
The old tool apparently lets you put any "target." in "target_overrides" without complaining, and it just seems to ignore it if the parameter you're trying to "override" doesn't exist. The new tools error in this case because the documentation states "It is an error for the application configuration to override an undefined configuration parameter." So, I think the "fix" here is to remove your |
thank you, I don't understand how that works, how can mbed see the lib if it's not required by anyone? |
target.requires was never a valid target_override. See ARMmbed#162 for details.
target.requires was never a valid target_override. See ARMmbed#162 for details.
target.requires was never a valid target_override. See ARMmbed#162 for details. Partially reverts 6a99b43.
Description
Version: 4.2.0
Ubuntu 20.04 LTS
Issue request type
Configuration fails with target override for requires:
This should work the same as
requires
in the root of the config. Currently it fails withThe text was updated successfully, but these errors were encountered: