Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build errors in programs/ssl/ssl_server2.c involving MBEDTLS_X509_CRL_PARSE_C #560

Closed
inestlerode opened this issue Jul 29, 2016 · 2 comments

Comments

Projects
None yet
5 participants
@inestlerode
Copy link

commented Jul 29, 2016

In mbed TLS 2.3.0 there are build errors in programs/ssl/ssl_server.c if the library is configured without MBEDTLS_X509_CRL_PARSE_C (there are unguarded calls to mbedtls_x509_crl_free and mbedtls_x509_crl_init and mbedtls_x509_crl_parse_file).

See the attached patch that gets rid of these calls if the library isn't built with MBEDTLS_X509_CRL_PARSE_C.

ssl_server2_patch.txt

@pjbakker

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2016

Thanks for noticing. By sending in a patch, we will need to ask you to sign a CLA for us to be able to handle this issue further.

So to accept your current contributions or any future contributions we will need a Contributor’s Licence Agreement (CLA) signed or authorised by yourself. You can find an agreement to sign here, which can be signed and returned to us, or you could create an mbed account and accept a slightly different agreement here with a click through if this is a personal contribution.

@ciarmcom ciarmcom added the mirrored label Sep 2, 2016

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Sep 2, 2016

ARM Internal Ref: IOTSSL-954

RonEld added a commit to RonEld/mbedtls that referenced this issue Apr 4, 2019

Add guards for MBEDTLS_X509_CRL_PARSE_C in sample
Add checks in `ssl_server2` that `MBEDTLS_X509_CRL_PARSE_C` is defined
to fix compilation issue. Fixes ARMmbed#560.

@RonEld RonEld referenced this issue Apr 4, 2019

Merged

Add guards for MBEDTLS_X509_CRL_PARSE_C in sample #2540

1 of 4 tasks complete

@RonEld RonEld added the fix available label Apr 4, 2019

RonEld added a commit to RonEld/mbedtls that referenced this issue Apr 4, 2019

Add guards for MBEDTLS_X509_CRL_PARSE_C in sample
Add checks in `ssl_server2` that `MBEDTLS_X509_CRL_PARSE_C` is defined
to fix compilation issue. Fixes ARMmbed#560.

RonEld added a commit to RonEld/mbedtls that referenced this issue Apr 4, 2019

Add guards for MBEDTLS_X509_CRL_PARSE_C in sample
Add checks in `ssl_server2` that `MBEDTLS_X509_CRL_PARSE_C` is defined
to fix compilation issue. Fixes ARMmbed#560.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.