Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

most selftest function declarations are not surrounded by `MBEDTLS_SELF_TEST` #971

Closed
RonEld opened this issue Jun 19, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@RonEld
Copy link
Contributor

commented Jun 19, 2017

most of the selftest function declarations are not surrounded by ``#if defined(MBEDTLS_SELF_TEST)` check.
Note: The .c files function implementations are surrounded
sha512.h
aes.h
ctr_drbg.h
ripemd160.h
arc4.h
dhm.h
md5.h
base64.h
xtea.h
x509.h
camelilia.h
pkcs5.h
md2
md4
gcm.h
sha256.h
bignum.h
sha1.h
rsa.h
des.h

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jun 19, 2017

ARM Internal Ref: IOTSSL-1470

RonEld added a commit to RonEld/mbedtls that referenced this issue Jun 20, 2017

Add `MBEDTLS_SELF_TEST` check in header files
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue ARMmbed#971

RonEld added a commit to RonEld/mbedtls that referenced this issue Jun 21, 2017

Add `MBEDTLS_SELF_TEST` check in header files
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue ARMmbed#971

RonEld added a commit to RonEld/mbedtls that referenced this issue Jun 21, 2017

Add `MBEDTLS_SELF_TEST` check in header files
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue ARMmbed#971
@RonEld

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2017

This is a subset of #660

RonEld added a commit to RonEld/mbedtls that referenced this issue Jun 21, 2017

Add `MBEDTLS_SELF_TEST` check in header files
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue ARMmbed#971

RonEld added a commit to RonEld/mbedtls that referenced this issue May 21, 2018

Add `MBEDTLS_SELF_TEST` check in header files
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue ARMmbed#971

gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls that referenced this issue Oct 12, 2018

@sbutcher-arm

This comment has been minimized.

Copy link
Collaborator

commented Jan 11, 2019

PR #975 has been merged. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.