Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes different off by ones #1663
Fixes different off by one overreads
I guess so
These do not seem security issues as the orignal buffer is overgrown.
Steps to test or reproduce
Outline the steps to test or reproduce the PR here.
@catenacyber Thanks for your contribution! The fixes look good, however:
This should be backported to 2.7 and 2.1 (our current maintained branches). This is done by creating new branches based on those with the backports, and then one new PR for each backport, with the same title as this one and a "Backport 2.x:" prefix, and "backport of #1663" as the PR cover text.
I am pushing an update
Ok, but how so ?
Ok, I will do it when build is green
Thanks for updating the PR. Unfortunately it looks like the CI is seeing some other issues now.
Yes, that's the way it's done. You'll need to create section for the next release as
From the github interface, it looks like that's what you're already doing, and this is indeed correct. (Our main branch is called development, and master only points to the latest stable release.)
I think it's your choice, you can either go ahead with the backports now, with a slight risk of having to backports changes again if Hanno requests any, or wait for his review to avoid that risk, but then you'll be waiting. (If it helps, I think most people in the team tend to go ahead with backports once we've received one approval, but that's still a personal choice.)