Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "mbedtls/" prefix in include file path #2319

Merged
merged 6 commits into from Jan 24, 2019

Conversation

@amisare
Copy link
Contributor

commented Dec 28, 2018

Status

READY

Additional comments

Fix for file not found, which was reporting in header files. In header files at mbedlts/include folder, The include path has prefix "mbedtls/" may cause the header file not be found in the case of mbedtls as a dynamic/static library.

Todos

  • Tests
  • Documentation
  • Changelog updated
  • Backported

amisare added some commits Dec 28, 2018

@amisare amisare changed the title Fix include file path Remove "mbedtls/" prefix in include file path Dec 28, 2018

amisare added some commits Dec 28, 2018

@RonEld

This comment has been minimized.

Copy link
Contributor

commented Dec 30, 2018

@amisare Thank you for your interest in Mbed TLS!
We are currently in the process of CLA acceptance, therefore labeling this PR as "CLA requested".

Note: this is related to #921 which was merged before these new includes were added, and to #857

@RonEld RonEld added bug CLA valid and removed CLA requested labels Dec 30, 2018

@RonEld
Copy link
Contributor

left a comment

The code Looks good to me.
I added my comment on the ChangeLog phrasing.

Show resolved Hide resolved ChangeLog Outdated
@sbutcher-arm
Copy link
Collaborator

left a comment

ChangeLog needs attention, but can be fixed in merge.

ChangeLog Outdated

Bugfix
* Fix for file not found, which was reporting in header files.
In header files at mbedlts/include folder, The include path has prefix

This comment has been minimized.

Copy link
@sbutcher-arm

sbutcher-arm Jan 3, 2019

Collaborator

Typo. Should be 'include/mbedtls', and 'the' shouldn't be capitalised. Not a blocker and can be fixed in merge.

ChangeLog Outdated
* Fix for file not found, which was reporting in header files.
In header files at mbedlts/include folder, The include path has prefix
"mbedtls/" may cause the header file not be found in the case of
mbedtls as a dynamic/static library.

This comment has been minimized.

Copy link
@sbutcher-arm

sbutcher-arm Jan 3, 2019

Collaborator

Need to credit @amisare. Not a blocker and can be fixed in merge.

@sbutcher-arm

This comment has been minimized.

Copy link
Collaborator

commented Jan 3, 2019

@RonEld - I can fix the ChangeLog in merge. If you see nothing else as wrong, can you please approve? Thanks.

@sbutcher-arm

This comment has been minimized.

Copy link
Collaborator

commented Jan 3, 2019

Needs backporting, but the same PR can be used on branch 2.16.

Update ChangeLog
Co-Authored-By: amisare <243297288@qq.com>
@amisare

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2019

@RonEld @sbutcher-arm I try to fix the ChangeLog. if it still has some error, you can modify it according to your rules.

@RonEld

RonEld approved these changes Jan 6, 2019

@RonEld RonEld referenced this pull request Jan 7, 2019

Merged

Include configuration file to headers #1375

2 of 4 tasks complete

@sbutcher-arm sbutcher-arm merged commit 5c0b5b5 into ARMmbed:development Jan 24, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.