Skip to content

Upgrade flutter from 3.35.3 to 3.38.5#181

Merged
aadishsamir123 merged 3 commits into
mainfrom
phone+wear/chore/flutter-upgrade-to-3.38.5
Dec 31, 2025
Merged

Upgrade flutter from 3.35.3 to 3.38.5#181
aadishsamir123 merged 3 commits into
mainfrom
phone+wear/chore/flutter-upgrade-to-3.38.5

Conversation

@aadishsamir123

@aadishsamir123 aadishsamir123 commented Dec 31, 2025

Copy link
Copy Markdown
Member

This pull request updates the project to use Flutter version 3.38.5 throughout the codebase and CI/CD workflows, and bumps the app versions for both phone and WearOS builds. It also makes minor improvements to workflow file formatting and updates documentation to reflect these changes.

Flutter version upgrade and consistency:

  • Upgraded Flutter version from 3.35.3 to 3.38.5 in all GitHub Actions workflows, including CI, build verification, linting, and production deployment for both phone and WearOS. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]
  • Updated documentation (README.md, .github/copilot-instructions.md) to reflect the new Flutter version. [1] [2] [3] [4]

App version bump:

  • Increased app version codes and names for both phone and WearOS product flavors in android/app/build.gradle.kts (e.g., phone: 5.0.3 → 5.0.4, wear: 1.2.3 → 1.2.4).
  • Updated the overall app version in pubspec.yaml from 5.0.3-other to 5.0.4-other.

Workflow and formatting improvements:

  • Standardized YAML formatting for workflow file paths and Java version fields (single to double quotes, consistent style). [1] [2] [3] [4] [5] [6]
  • Minor whitespace cleanup in workflow files.

Summary by CodeRabbit

  • Chores
    • Updated Flutter SDK to 3.38.5 across CI/CD workflows
    • Bumped app version to 5.0.4 for phone and wear builds
    • Upgraded Gradle wrapper and Android Gradle Plugin versions
    • Standardized YAML quoting/spacing and Java configuration in workflows
    • Updated README Flutter version badge
    • Enabled cancel-in-progress for build concurrency

✏️ Tip: You can customize this high-level summary in your review settings.

@aadishsamir123 aadishsamir123 self-assigned this Dec 31, 2025
@coderabbitai

coderabbitai Bot commented Dec 31, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR updates Flutter SDK references from 3.35.3 to 3.38.5 across CI/CD workflows and README, bumps app and pubspec versions (phone: 5.0.4, wear: 1.2.4, pubspec: 5.0.4-other), upgrades Gradle and Android Gradle Plugin versions, and normalizes YAML/quoting in workflow files.

Changes

Cohort / File(s) Summary
GitHub Workflows (CI/CD & lint)
.github/workflows/...
\ .github/workflows/CD-Prod-Play-Phone.yml`, `.github/workflows/CD-Prod-Play-WearOS.yml`, `.github/workflows/CI.yml`, `.github/workflows/build-verification.yml`, `.github/workflows/lint.yml``
Bumped Flutter setup from 3.35.33.38.5; normalized YAML formatting (removed extra spaces in lists, converted single to double quotes); Java setup values switched to double-quoted; added cancel-in-progress: true under concurrency in build-verification.yml.
Repository docs / instructions
\ README.md`, `.github/copilot-instructions.md``
Updated Flutter version badge/text from ^3.35.3^3.38.5.
Android app config
\ android/app/build.gradle.kts``
Phone flavor: phoneVersionCode 8 → 9, versionName "5.0.3-phone""5.0.4-phone"; Wear flavor: wearVersionCode 5 → 6, versionName "1.2.3-wear""1.2.4-wear".
Project version
\ pubspec.yaml``
Bumped package version from 5.0.3-other5.0.4-other.
Gradle / AGP updates
\ android/gradle/wrapper/gradle-wrapper.properties`, `android/settings.gradle.kts``
Gradle wrapper URL updated to gradle-8.13-all.zip; Android Gradle Plugin declaration updated to 8.13.2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Upgrade flutter from 3.35.3 to 3.38.5' accurately describes the primary change in the pull request and is clear, concise, and specific.
Description check ✅ Passed The description is comprehensive, covering Flutter version upgrades, app version bumps, workflow formatting improvements, and includes multiple references to relevant changes throughout the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e78ab6 and 8583b53.

📒 Files selected for processing (2)
  • android/gradle/wrapper/gradle-wrapper.properties
  • android/settings.gradle.kts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-25T11:26:43.162Z
Learning: Applies to .github/workflows/CD-Prod-Play-WearOS.yml : WearOS CD workflow must build `--flavor wear --target=lib/wear/wear_main.dart` and upload to wear:production track on Play Store
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-25T11:26:43.162Z
Learning: Applies to .github/workflows/CD-Prod-Play-Phone.yml : Phone CD workflow must build `--flavor phone --target=lib/main.dart` and upload to production Play Store track via `r0adkll/upload-google-play`
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-25T11:26:43.162Z
Learning: Applies to .github/workflows/CI.yml : CI workflow must run `flutter analyze --no-fatal-infos`, `flutter pub get`, and `flutter test --coverage` with Codecov integration; use parallel execution for faster feedback
📚 Learning: 2025-12-25T11:26:43.162Z
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-25T11:26:43.162Z
Learning: Applies to android/app/build.gradle : Version code format must be `XXYYYYYYY` where XX=platform (30=phone, 40=wear), YYYYYYY=versionCode

Applied to files:

  • android/settings.gradle.kts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Build Phone Flavor
  • GitHub Check: Build Web (WASM)
  • GitHub Check: Tests & Coverage
  • GitHub Check: Build WearOS Flavor
  • GitHub Check: Seer Code Review
  • GitHub Check: Build Web (WASM)
  • GitHub Check: Build WearOS (Debug)
  • GitHub Check: Build Phone (Debug)
🔇 Additional comments (2)
android/gradle/wrapper/gradle-wrapper.properties (1)

5-5: LGTM! Gradle 8.13 is compatible with AGP 8.13.2 and Flutter 3.38.5.

AGP 8.13 requires Gradle 8.13 minimum, and Flutter 3.38 was tested with Gradle 8.14, with 8.13 being the minimum required for AGP 8.11.1. The upgrade from 8.7 to 8.13 is necessary and appropriate for this Flutter version bump.

android/settings.gradle.kts (1)

21-21: [Your rewritten review comment text here]
[Exactly ONE classification tag]


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added app:phone Related to ShopSync Phone/Web app app:wearos Related to ShopSync WearOS app bump:phone Version bump for the Phone/Web app bump:wearos Version bump for the WearOS app semver-minor Minor Updates labels Dec 31, 2025
@aadishsamir123 aadishsamir123 merged commit 72edd43 into main Dec 31, 2025
23 of 30 checks passed
@aadishsamir123 aadishsamir123 deleted the phone+wear/chore/flutter-upgrade-to-3.38.5 branch December 31, 2025 02:10
@coderabbitai coderabbitai Bot mentioned this pull request Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:phone Related to ShopSync Phone/Web app app:wearos Related to ShopSync WearOS app bump:phone Version bump for the Phone/Web app bump:wearos Version bump for the WearOS app semver-minor Minor Updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant