Skip to content

Update Hindi translations#189

Merged
aadishsamir123 merged 2 commits into
mainfrom
l10n/hi
Jan 2, 2026
Merged

Update Hindi translations#189
aadishsamir123 merged 2 commits into
mainfrom
l10n/hi

Conversation

@aadishsamir123

@aadishsamir123 aadishsamir123 commented Jan 2, 2026

Copy link
Copy Markdown
Member

This pull request updates the Hindi localization strings to provide more accurate and user-friendly translations, and also bumps the app version numbers for both the phone and wear platforms to reflect these changes.

Localization improvements:

  • Updated lib/l10n/app_localizations_hi.dart with improved and more natural Hindi translations for various UI strings, replacing English placeholders with proper Hindi equivalents.

Version updates:

  • Increased the app version numbers for the phone and wear builds in android/app/build.gradle.kts (versionName updated to 5.1.1-phone and 1.3.1-wear respectively).
  • Updated the overall app version in pubspec.yaml to 5.1.1-other.

Summary by CodeRabbit

  • Localization

    • Added comprehensive Hindi language translations for user interface elements, including labels, prompts, error messages, descriptions, and additional UI text throughout the application.
  • Chores

    • Updated application versions to 5.1.1 for phone and wear variants, and package version to align with release requirements.

✏️ Tip: You can customize this high-level summary in your review settings.

@aadishsamir123 aadishsamir123 self-assigned this Jan 2, 2026
@aadishsamir123 aadishsamir123 added the translation Change in translations label Jan 2, 2026
@coderabbitai

coderabbitai Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request bumps application versions across multiple platforms and flavor configurations, incrementing patch versions from 5.1.0 to 5.1.1 for the phone flavor and from 1.3.0 to 1.3.1 for the wear flavor. Additionally, Hindi language translations are updated throughout the localization file.

Changes

Cohort / File(s) Summary
Version Bumps
android/app/build.gradle.kts, pubspec.yaml
Increments versionName from 5.1.0 to 5.1.1 (phone flavor and general package); wear flavor bumped from 1.3.0 to 1.3.1. versionCode unchanged.
Localization Updates
lib/l10n/app_localizations_hi.dart
Hindi translations updated for numerous UI strings, labels, prompts, descriptions, and error messages. String return values changed; method signatures and control flow remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #181: Modifies version metadata files with app/package version string bumps
  • #173: Updates the same Android Gradle configuration and localization assets
  • #185: Contains overlapping changes to localization and version configuration files

Suggested labels

enhancement, app:phone, app:wearos, bump:phone, bump:wearos

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update Hindi translations' is directly related to the main change in the changeset—updating Hindi localization strings in app_localizations_hi.dart.
Description check ✅ Passed The pull request description is comprehensive, detailing both localization improvements and version updates across all modified files with clear structure and specificity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa52db1 and 49465f7.

📒 Files selected for processing (3)
  • android/app/build.gradle.kts
  • lib/l10n/app_localizations_hi.dart
  • pubspec.yaml
🧰 Additional context used
📓 Path-based instructions (4)
android/**

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Define version code format as XXYYYYYYY where XX=platform (30=phone, 40=wear) and YYYYYYY=versionCode; include key.properties (keystore config) and sentry.properties (debug symbols) for releases

Files:

  • android/app/build.gradle.kts
**/*.dart

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use snake_case for file names, PascalCase for classes, and camelCase for variables and functions

Files:

  • lib/l10n/app_localizations_hi.dart
lib/**/*.dart

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use StreamBuilder and StreamBuilder for real-time Firebase sync; use FutureBuilder for one-time async operations; use setState() and StatefulWidget for local state

Files:

  • lib/l10n/app_localizations_hi.dart
pubspec.yaml

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Include dev_dependencies: mockito (^5.4.4), fake_cloud_firestore (^2.5.0), firebase_auth_mocks (^0.14.0), coverage (^7.0.0) for testing infrastructure

Files:

  • pubspec.yaml
🧠 Learnings (11)
📓 Common learnings
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 185
File: lib/l10n/app_localizations_de.dart:12-49
Timestamp: 2026-01-02T07:34:20.743Z
Learning: In the ASDev-Official/shopsync repository, all localization files (lib/l10n/app_localizations_*.dart) are auto-generated from Weblate. Direct edits to these files would be overwritten. Any translation corrections or updates must be made in Weblate, not in the PR code. Do not suggest direct code edits to these localization files.
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-31T02:11:10.536Z
Learning: Applies to android/app/build.gradle : Define build flavors with dimension 'platform' for phone (flavor: phone) and wear (flavor: wear) targets
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 147
File: android/app/build.gradle:51-58
Timestamp: 2025-12-05T14:08:58.025Z
Learning: For android/app/build.gradle in the shopsync repository: Use version code format `XXYYYYYYY` where XX=platform (30=phone, 40=wear), YYYYYYY=versionCode. Phone uses base 300000000, wear uses base 400000000.
📚 Learning: 2025-12-31T02:11:10.536Z
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-31T02:11:10.536Z
Learning: Applies to android/app/build.gradle : Define build flavors with dimension 'platform' for phone (flavor: phone) and wear (flavor: wear) targets

Applied to files:

  • android/app/build.gradle.kts
📚 Learning: 2025-12-25T01:27:42.741Z
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 173
File: android/app/build.gradle.kts:54-72
Timestamp: 2025-12-25T01:27:42.741Z
Learning: In android/app/build.gradle.kts, verify that manifestPlaceholders.clear() in the phone and wear productFlavors is intentional to allow per-flavor manifest placeholder management (e.g., WearOS hardware flags). Confirm that credential manager is enabled in each flavor-specific file rather than inherited from defaultConfig, and ensure there is no unintended inheritance of manifest placeholders or credential settings from defaultConfig.

Applied to files:

  • android/app/build.gradle.kts
📚 Learning: 2025-12-05T14:08:58.025Z
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 147
File: android/app/build.gradle:51-58
Timestamp: 2025-12-05T14:08:58.025Z
Learning: For android/app/build.gradle in the shopsync repository: Use version code format `XXYYYYYYY` where XX=platform (30=phone, 40=wear), YYYYYYY=versionCode. Phone uses base 300000000, wear uses base 400000000.

Applied to files:

  • android/app/build.gradle.kts
📚 Learning: 2025-12-31T02:11:10.536Z
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-31T02:11:10.536Z
Learning: Applies to android/** : Define version code format as XXYYYYYYY where XX=platform (30=phone, 40=wear) and YYYYYYY=versionCode; include key.properties (keystore config) and sentry.properties (debug symbols) for releases

Applied to files:

  • android/app/build.gradle.kts
📚 Learning: 2025-12-31T02:11:10.536Z
Learnt from: CR
Repo: ASDev-Official/shopsync PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-31T02:11:10.536Z
Learning: Applies to .github/workflows/CD-Prod-Play-WearOS.yml : Manually triggered workflow that builds wear appbundle with --release --flavor wear --target=lib/wear/wear_main.dart and uploads to Play Store wear:production track

Applied to files:

  • android/app/build.gradle.kts
📚 Learning: 2025-12-28T07:03:07.543Z
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 0
File: :0-0
Timestamp: 2025-12-28T07:03:07.543Z
Learning: For Android version references in PR titles, code comments, or documentation, use the public-facing name (e.g., "Android 16") even when the code uses the API level (e.g., targetSdk = 36).

Applied to files:

  • android/app/build.gradle.kts
📚 Learning: 2025-12-25T01:28:15.004Z
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 173
File: android/app/build.gradle.kts:34-43
Timestamp: 2025-12-25T01:28:15.004Z
Learning: In Gradle Kotlin DSL scripts (build.gradle.kts) used for Android apps, when configuring signingConfigs, use unsafe casts (as String) for keystore properties (keyAlias, keyPassword, storePassword) so that a missing value fails the build immediately. This enforces that required keystore values are provided at build configuration time. If a value might legitimately be absent, consider validating early and failing fast rather than relying on null-safe access (as? String).

Applied to files:

  • android/app/build.gradle.kts
📚 Learning: 2025-12-16T01:16:30.495Z
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 167
File: lib/l10n/app_localizations_de.dart:7-15
Timestamp: 2025-12-16T01:16:30.495Z
Learning: In lib/l10n/app_localizations_*.dart (languages de, es, fr, hi, it, ja, ko, ru, zh), English strings serve as fallback placeholders for untranslated content. The localization system falls back to English until translations are added via Weblate. This behavior is intentional and should not be flagged during reviews.

Applied to files:

  • lib/l10n/app_localizations_hi.dart
📚 Learning: 2026-01-02T07:34:20.743Z
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 185
File: lib/l10n/app_localizations_de.dart:12-49
Timestamp: 2026-01-02T07:34:20.743Z
Learning: In ASDev-Official/shopsync, all localization files matching lib/l10n/app_localizations_*.dart are auto-generated from Weblate. Do not edit these files directly; translation updates must be made in Weblate. Do not propose or apply direct edits to these generated localization files in PRs.

Applied to files:

  • lib/l10n/app_localizations_hi.dart
📚 Learning: 2025-12-16T03:34:14.872Z
Learnt from: aadishsamir123
Repo: ASDev-Official/shopsync PR: 167
File: lib/l10n/app_localizations_zh.dart:5-5
Timestamp: 2025-12-16T03:34:14.872Z
Learning: In Dart, you can use // ignore_for_file: type=lint to disable all lint rules for a file. This directive is commonly used in auto-generated files under lib/l10n/ (e.g., localization files) and was introduced in Dart 2.15. Use this sparingly and prefer scoping ignores to specific rules when possible; avoid applying it to hand-written code unless absolutely necessary.

Applied to files:

  • lib/l10n/app_localizations_hi.dart
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Tests & Coverage
  • GitHub Check: Build Phone Flavor
  • GitHub Check: Build Web (WASM)
  • GitHub Check: Build WearOS Flavor
  • GitHub Check: Build WearOS (Debug)
  • GitHub Check: Build Web (WASM)
  • GitHub Check: Build Phone (Debug)
🔇 Additional comments (4)
android/app/build.gradle.kts (2)

61-61: LGTM - Phone version bump applied correctly.

The version name increment from 5.1.0-phone to 5.1.1-phone is appropriate for a translation update release.


69-69: LGTM - Wear version bump applied correctly.

The version name increment from 1.3.0-wear to 1.3.1-wear aligns with the phone flavor's patch version bump.

pubspec.yaml (1)

5-5: LGTM - Package version bump consistent with platform versions.

The version increment to 5.1.1-other aligns with the Android flavor versions and is appropriate for this translation update.

lib/l10n/app_localizations_hi.dart (1)

12-1759: LGTM - Hindi translations updated successfully.

The Hindi localization strings have been updated throughout the file. The remaining English strings (e.g., lines 128-149, 152-221) serve as intentional fallback placeholders until translations are completed in Weblate.

Based on learnings, this file is auto-generated from Weblate and should not be edited directly in code reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added app:phone Related to ShopSync Phone/Web app app:wearos Related to ShopSync WearOS app bump:phone Version bump for the Phone/Web app bump:wearos Version bump for the WearOS app enhancement New feature or request labels Jan 2, 2026
@aadishsamir123 aadishsamir123 merged commit 7d325e5 into main Jan 2, 2026
22 of 29 checks passed
@aadishsamir123 aadishsamir123 deleted the l10n/hi branch January 2, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:phone Related to ShopSync Phone/Web app app:wearos Related to ShopSync WearOS app bump:phone Version bump for the Phone/Web app bump:wearos Version bump for the WearOS app enhancement New feature or request translation Change in translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant