New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links at end of comments are broken by </p> tag #324

Closed
dfarrell07 opened this Issue Oct 31, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@dfarrell07

dfarrell07 commented Oct 31, 2014

Links at the end of comments on questions/answers get a </p> tag appended to them, which breaks the links. The comment on this question is an example. It resolves to https://bugs.opendaylight.org/</p>, which clearly 404s.

@slel

This comment has been minimized.

Show comment
Hide comment
@slel

slel Oct 31, 2014

A workaround is to add space and period after links, eg write

https://bugs.opendaylight.org/ .

instead of

https://bugs.opendaylight.org/

A similar issue is described at #274.

slel commented Oct 31, 2014

A workaround is to add space and period after links, eg write

https://bugs.opendaylight.org/ .

instead of

https://bugs.opendaylight.org/

A similar issue is described at #274.

@dfarrell07

This comment has been minimized.

Show comment
Hide comment
@dfarrell07

dfarrell07 Oct 31, 2014

#274 looks like it's for a similar problem on user profile pages. The OP does mention this issue, but from what I can gather from the patch and users' comments about the patch bd98e62 doesn't address the comment issue. Could totally be wrong though, not a web dev pro.

dfarrell07 commented Oct 31, 2014

#274 looks like it's for a similar problem on user profile pages. The OP does mention this issue, but from what I can gather from the patch and users' comments about the patch bd98e62 doesn't address the comment issue. Could totally be wrong though, not a web dev pro.

@slel

This comment has been minimized.

Show comment
Hide comment
@slel

slel Oct 31, 2014

You're right, #274 is a similar problem elsewhere. It's not clear if the fix for #274 could be adapted to the right place in the source code to fix this bug too...

slel commented Oct 31, 2014

You're right, #274 is a similar problem elsewhere. It's not clear if the fix for #274 could be adapted to the right place in the source code to fix this bug too...

@slel

This comment has been minimized.

Show comment
Hide comment
@slel

slel Apr 7, 2016

Is this really fixed? What version of Askbot has this?
I am still seeing this bug with the link at the end of kcrisman's comment to the question at
http://ask.sagemath.org/question/10004/latex-form-of-product-of-non-commuting-variables/

slel commented Apr 7, 2016

Is this really fixed? What version of Askbot has this?
I am still seeing this bug with the link at the end of kcrisman's comment to the question at
http://ask.sagemath.org/question/10004/latex-form-of-product-of-non-commuting-variables/

@slel

This comment has been minimized.

Show comment
Hide comment
@slel

slel Aug 29, 2016

@evgenyfadeev can you reopen this issue? It doesn't seem to be fixed.
Or maybe the fix is not live at "Ask Askbot", see last link in my comment at
http://askbot.org/en/question/8878/reasonable-site-load-time-with-pingdom/?answer=8882#post-id-8882

slel commented Aug 29, 2016

@evgenyfadeev can you reopen this issue? It doesn't seem to be fixed.
Or maybe the fix is not live at "Ask Askbot", see last link in my comment at
http://askbot.org/en/question/8878/reasonable-site-load-time-with-pingdom/?answer=8882#post-id-8882

@slel

This comment has been minimized.

Show comment
Hide comment
@slel

slel Apr 8, 2018

Ask Sage at https://ask.sagemath.org/ currently runs Askbot 0.7.56,
and it seems that for newly created comments, links at the end of
comments don't get the extra trailing html end-of-paragraph ( </p>)
tag, so this indeed appears to be fixed, but one should not that old
posts are not fixed by upgrading to a new version, one needs to edit
them in order for the links at the end of comments to start working.

slel commented Apr 8, 2018

Ask Sage at https://ask.sagemath.org/ currently runs Askbot 0.7.56,
and it seems that for newly created comments, links at the end of
comments don't get the extra trailing html end-of-paragraph ( </p>)
tag, so this indeed appears to be fixed, but one should not that old
posts are not fixed by upgrading to a new version, one needs to edit
them in order for the links at the end of comments to start working.

@slel

This comment has been minimized.

Show comment
Hide comment
@slel

slel Apr 9, 2018

But "Ask Askbot" at https://askbot.org/ currently runs Askbot 0.7.58
and the problem persists there... So not clear this issue is fixed really.

slel commented Apr 9, 2018

But "Ask Askbot" at https://askbot.org/ currently runs Askbot 0.7.58
and the problem persists there... So not clear this issue is fixed really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment