Fix encoding problems when sharing a question with special characters #118

merged 1 commit into from Mar 23, 2013


None yet

2 participants

adobo commented Mar 22, 2013

Twitter complains with the following error message when sharing a question that contains special characters, such as accented vowels:

Invalid Unicode value in one or more parameters

The problem is that JS encode() function doesn't handle UTF-8 characters, but encodeURIComponent() actually does.

This PR replaces escape() with encodeURIComponent() when sharing a question.

@evgenyfadeev evgenyfadeev merged commit 5e0c199 into ASKBOT:master Mar 23, 2013

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment