Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern django cache configuration in settings #442

Merged
merged 1 commit into from Aug 7, 2015
Merged

Use modern django cache configuration in settings #442

merged 1 commit into from Aug 7, 2015

Conversation

stapelberg
Copy link

Changing CACHE_BACKEND to memcached://127.0.0.1:11211/ has no effect at all anymore with django 1.8.

@stapelberg
Copy link
Author

Note that I’m not 100% sure about LIVESETTINGS_CACHE_TIMEOUT (is it still necessary?)
and CACHE_MIDDLEWARE_ANONYMOUS_ONLY (what does it do/how does it translate to django 1.8 settings?), so I didn’t touch them. If I should also change them, please advise.

@evgenyfadeev
Copy link
Member

There are two settings files templates, the more important one is with .mustache extention.

Also could you verify please that removed settings are not used/updated elsewhere in the code by searching the code base for every use of removed values.

Changing `CACHE_BACKEND` to `memcached://127.0.0.1:11211/` has no effect at all anymore with django 1.8.
@stapelberg
Copy link
Author

Sorry for the late reply, this fell of my radar.

I’ve updated askbot/deps/livesettings/models.py, the only other reference to any of the cache-related settings is askbot/startup_procedures.py, which was already updated.

@evgenyfadeev Can you take another look at merging this please?

evgenyfadeev added a commit that referenced this pull request Aug 7, 2015
Use modern django cache configuration in settings
@evgenyfadeev evgenyfadeev merged commit 0454177 into ASKBOT:master Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants