No description provided.
added setup.py: fixes #179
This pull request passes (merged 4e6b453 into d355a66).
Don’t want to decide on this without prior discussion. But for educational purposes, it would be nice if the commit message followed our conventions: http://aspp.github.com/pelita/development.html
I think this (or something similar) can be merged only when we have a stable release. Until that moment people are supposed to pull from github quite often, and using distutils/setuptools in this case is cumbersome and prone to errors (dangling pyc files, no proper de-installation procedure)...
I guess people who use setup.py should know what they are doing. I like using setuptools with virtualenv which makes testing of different version of software much easier
added pelitagame script to setup.py
This pull request fails (merged ae82993 into d355a66).
FIX: team_name in SimpleTeam is respected (fixes #196)
OK, I had a look, and I see the following problems:
1. license line is wrong
2. it would be better to explicitly specify supported python versions
Well, the version is also incorrect. But then again, I know nothing about setup.py.
(Of course, it has been correct at the time of the pull request but it may be something to do more generically.)
@keszybz I took the license from README.md:
Information about authors, mailing list, the license (2-Clause-BSD) and acknowledgements can be found at: http://aspp.github.com/pelita/info.html
@keszybz 2. I do not know whether there is any official way to define python version. I have never seen anyone doing it.
added python version classifiers
any specific reason to close it now? (Aside from the fact that it was silent for 4 years ;))
Mostly that, yes.
You can open a new issue for discussion and attach this PR, though. :)